chore: add typecheck for expect tests (#13383)

jestjs · Oct 4, 2022 · c660c16 · c660c16
1 parent dcd39f0
commit c660c16
Show file tree

Hide file tree

Showing 9 changed files with 503 additions and 238 deletions.
diff --git a/package.json b/package.json
@@ -113,7 +113,7 @@
     "test": "yarn lint && yarn jest",
     "typecheck": "yarn typecheck:examples && yarn typecheck:tests",
     "typecheck:examples": "tsc -p examples/angular --noEmit && tsc -p examples/expect-extend --noEmit && tsc -p examples/typescript --noEmit",
-    "typecheck:tests": "tsc -b packages/{babel-jest,babel-plugin-jest-hoist,diff-sequences}/src/__tests__",
+    "typecheck:tests": "tsc -b packages/{babel-jest,babel-plugin-jest-hoist,diff-sequences,expect}/src/__tests__",
     "verify-old-ts": "node ./scripts/verifyOldTs.mjs",
     "verify-pnp": "node ./scripts/verifyPnP.mjs",
     "watch": "yarn build:js && node ./scripts/watch.mjs",

diff --git a/packages/expect/src/__tests__/extend.test.ts b/packages/expect/src/__tests__/extend.test.ts
@@ -9,11 +9,11 @@
 import {equals, iterableEquality, subsetEquality} from '@jest/expect-utils';
 import {alignedAnsiStyleSerializer} from '@jest/test-utils';
 import * as matcherUtils from 'jest-matcher-utils';
-import jestExpect from '../';
+import importedExpect from '../';
 
 expect.addSnapshotSerializer(alignedAnsiStyleSerializer);
 
-jestExpect.extend({
+importedExpect.extend({
   toBeDivisibleBy(actual: number, expected: number) {
     const pass = actual % expected === 0;
     const message: () => string = pass
@@ -52,11 +52,6 @@ jestExpect.extend({
 });
 
 declare module '../types' {
-  interface AsymmetricMatchers {
-    toBeDivisibleBy(expected: number): void;
-    toBeSymbol(expected: symbol): void;
-    toBeWithinRange(floor: number, ceiling: number): void;
-  }
   interface Matchers<R> {
     toBeDivisibleBy(expected: number): R;
     toBeSymbol(expected: symbol): R;
@@ -69,6 +64,17 @@ declare module '../types' {
   }
 }
 
+const jestExpect = importedExpect as typeof importedExpect & {
+  not: {
+    toBeDivisibleBy(expected: number): void;
+    toBeWithinRange(floor: number, ceiling: number): void;
+  };
+
+  toBeDivisibleBy(expected: number): void;
+  toBeSymbol(expected: symbol): void;
+  toBeWithinRange(floor: number, ceiling: number): void;
+};
+
 it('is available globally when matcher is unary', () => {
   jestExpect(15).toBeDivisibleBy(5);
   jestExpect(15).toBeDivisibleBy(3);

diff --git a/packages/expect/src/__tests__/matchers-toContain.property.test.ts b/packages/expect/src/__tests__/matchers-toContain.property.test.ts
@@ -7,7 +7,7 @@
  */
 
 import fc from 'fast-check';
-import expect from '..';
+import expect from '../';
 import {
   anythingSettings,
   assertSettings,

diff --git a/packages/expect/src/__tests__/matchers-toContainEqual.property.test.ts b/packages/expect/src/__tests__/matchers-toContainEqual.property.test.ts
@@ -7,7 +7,7 @@
  */
 
 import fc from 'fast-check';
-import expect from '..';
+import expect from '../';
 import {
   anythingSettings,
   assertSettings,

diff --git a/packages/expect/src/__tests__/matchers-toEqual.property.test.ts b/packages/expect/src/__tests__/matchers-toEqual.property.test.ts
@@ -7,7 +7,7 @@
  */
 
 import fc from 'fast-check';
-import expect from '..';
+import expect from '../';
 import {
   anythingSettings,
   assertSettings,

diff --git a/packages/expect/src/__tests__/matchers-toStrictEqual.property.test.ts b/packages/expect/src/__tests__/matchers-toStrictEqual.property.test.ts
@@ -8,7 +8,7 @@
 
 import * as assert from 'assert';
 import fc from 'fast-check';
-import expect from '..';
+import expect from '../';
 import {
   anythingSettings,
   assertSettings,