fix: support path based auto completion for unstable_mockModule method
#988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3910327078
💛 - Coveralls |
connectdotz
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #977 (comment)
Currently path based auto completion is supported for
jest.mock, but not forjest.unstable_mockModulemethod.The
jest.mockworks only with CJS modules. Thejest.unstable_mockModulemethod was introduced to supporting mocking of ESM modules. If I get it right, it is markedunstable, because it is not yet feature complete and can change outside of major releases. Otherwise this is official and the only way to mock ESM modules.At some point it will become
jest.mockModule. This means I will send another PR to removeunstable_from the regex.