Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix active editor files sometimes got attached to the wrong workspace folder #1108

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Feb 4, 2024

Fixed a bug that the active editor file might get attached to a wrong workspace folder (sometimes, deferred mode, race condition etc), even when the file is not under that workspace folder.

This could explain #1086, specifically in comment.

Also refactored the TestResultProvider.isTestFile to return a deterministic boolean value by parsing the content instead of returning a "maybe" value originally.


Resolve #1086

@coveralls
Copy link

coveralls commented Feb 4, 2024

Pull Request Test Coverage Report for Build 7777442173

  • 0 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.946%

Totals Coverage Status
Change from base Build 7516526780: 0.001%
Covered Lines: 3917
Relevant Lines: 3925

💛 - Coveralls

@connectdotz connectdotz merged commit 9474880 into jest-community:master Feb 4, 2024
11 checks passed
@connectdotz connectdotz deleted the fix-file-in-wrong-ws branch February 4, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No tests are detected
2 participants