-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashed-args #1034
Dashed-args #1034
Conversation
Pull Request Test Coverage Report for Build 5262229101
💛 - Coveralls |
Changes have been tested. Coverage loss is inaccurate. |
With the latest preview build it still fails for list tests and watch all options even when useDashedArgs is set to true. Running tests individually from the test file works kinda (executing all tests regardless, which did not work at all before) Seeing this in the jest output, when starting VSCode
|
Was this merged? Does not seem to be working. |
It is merged and released in the pre-release v6.0.0. is that the version you tested? |
It is. Is there a way to check the jest-editor-support version? Perhaps that one did not get updated? |
yes if you got
it will not change the debug config though, which you can change manually - that was available since we introduced the debug config v2 a while back. @stefanrybacki use case is puzzling too. Can you also paste the full CLI the extension spawned? |
First of all, thank you so much for your project. This extension is the only one that is flexible enough to get close to working with angular and a multiroot project. I have almost given up on using jest many times now, because I have had a lot of headaches in the past trying to get it to work. However, with your extension, I can at least run all the tests from the context menu, as well as debug them, which is really amazing. Now back to the questions. The only output I see from jest console is this, even after enabling jest.debugMode:
If I open the developer console I see this:
|
Thanks for the kind words! 😄 I think I found the root cause in |
@rafagsiqueira and @stefanrybacki, the fix is in. Please feel free to try v6.0.1 pre-release and let me know if it resolves your issue. |
@connectdotz you are amazing! I can confirm it works on v6.0.1 pre-release. Thank you very much! |
People should note that it currently only works with the Here is a setup that works using |
@mjamin i opened a feature request with angular dev kit to pass the cli options to jest. What do you mean by a setup that works? Did you manage to configure the extension to work with @angular-devkit/build-angular:jest and the vscode-jest extension? |
@rafagsiqueira No, the setup is using |
@connectdotz I can confirm running tests now works for too, however debugging still used |
yes, the change did not include debug config, see comment here, specifically:
But you are right that I should update the release note to make sure people are aware of this. |
adding a new setting
jest.useDashedArgs
to convert all camelcase arguments (default) to dashed arguments. This is mainly to support angular projects that are deprecating camelcase arguments.The actual conversion is done in
jest-editor-support
(see jest-community/jest-editor-support#103). We are merely passing through this setting.resolve #923