Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding jest.enable setting and adjust workspace operations accordingly #1009

Merged
merged 3 commits into from
Apr 30, 2023

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Feb 10, 2023

Adding a new setting jest.enable to completely turn the extension off for a given workspace. Also, incorporate this in the monorepo setup tool so we will ignore the disabled workspace.

Note

  1. this indeed overlaps with the "disabledWorkspaceFolders" setting, albeit served different use cases.
  2. I wasn't sure if we really needed this feature since the user could simply use the vscode feature to disable the extension for the specific workspace. But it might be useful for the monorepo use cases, where you just want to disable a specific folder rather than the whole workspace. So go ahead added it to close the requirement.

resolve #984
resolve #981
resolve #993

@coveralls
Copy link

coveralls commented Feb 10, 2023

Pull Request Test Coverage Report for Build 4152419526

  • 43 of 43 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 97.751%

Totals Coverage Status
Change from base Build 4108646033: 0.03%
Covered Lines: 3407
Relevant Lines: 3430

💛 - Coveralls

@connectdotz connectdotz merged commit 98c9ad9 into jest-community:master Apr 30, 2023
@connectdotz connectdotz deleted the jest-enable branch April 30, 2023 20:40
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
jest-community#1009)

* adding jest.enable setting and adjust workspace operations accordingly

* address lint and coverage

* Update setup-monorepo.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants