Delete expect and jest-matcher-utils dependencies #332

keeganwitt · 2021-07-01T01:56:42Z

What

Don't depend on expect and jest-matcher-utils directly.

Why

utils are already injected into all the matchers.

Notes

Housekeeping

Unit tests
Documentation is up to date
No additional lint warnings
Typescript definitions are added/updated where relevant

SimenB

looks great! I have a couple of suggestions to reduce the diff, but the migration itself LGTM. I only commented in the first file, but the comments apply to them all

src/matchers/toBeAfter/index.js

SimenB · 2021-07-01T09:08:28Z

src/matchers/toBeAfter/index.js


-const failMessage = (received, after) => () =>
-  matcherHint('.toBeAfter', 'received', '') +
+const failMessage = (received, after, context) => () =>


Suggested change

const failMessage = (received, after, context) => () =>

const failMessage = (received, after, { matcherHint, printReceived }) => () =>

etc? again, to reduce diff

It would reduce diff, but I thought it was kinda nice that the matchers all followed the same pattern of all using context (although will now be utils when I make that change).

SimenB · 2021-07-01T09:11:49Z

jest-extended/src/utils/index.js

Line 1 in 0013709

import { equals } from 'expect/build/jasmineUtils';

remove this?

keeganwitt · 2021-07-01T14:06:52Z

jest-extended/src/utils/index.js

Line 1 in 0013709

import { equals } from 'expect/build/jasmineUtils';

remove this?

Where does the equals come from instead? This is outside a matcher, so nothing is injected, right?

SimenB · 2021-07-02T06:06:49Z

yeah, it cannot be imported like this, the matcher must inject it into the helper functions

keeganwitt · 2021-07-03T01:49:17Z

yeah, it cannot be imported like this, the matcher must inject it into the helper functions

Got it. Made that change.

SimenB

I'll rebase this since I've introduced a conflict in pretty much all files 🙈

src/matchers/index.test.js

CONTRIBUTING.md

codecov · 2021-07-09T09:08:11Z

Codecov Report

Merging #332 (08b9497) into main (cc53ef3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 08b9497 differs from pull request most recent head 5491f54. Consider uploading reports for the commit 5491f54 to get more accurate results

@@            Coverage Diff             @@
##              main      #332    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          137       109    -28     
  Lines          843       643   -200     
  Branches       143       100    -43     
==========================================
- Hits           843       643   -200

Impacted Files	Coverage Δ
src/matchers/toContainEntries/predicate.js	`100.00% <ø> (ø)`
src/matchers/toContainEntry/predicate.js	`100.00% <ø> (ø)`
src/matchers/toBeAfter/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeArray/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeArrayOfSize/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeBefore/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeBoolean/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeDate/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeEmpty/index.js	`100.00% <100.00%> (ø)`
src/matchers/toBeEmpty/predicate.js	`100.00% <100.00%> (ø)`
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc53ef3...5491f54. Read the comment docs.

SimenB · 2021-08-13T09:19:34Z

Seems this failed CI, could you rebase to retrigger?

keeganwitt · 2021-08-23T02:18:39Z

Seems this failed CI, could you rebase to retrigger?

Rebased, but the asymmetric matchers still aren't working.

SimenB · 2021-10-04T15:17:17Z

Right, so the failure is (imo) a bug in Jest. I've opened up a PR over there (jestjs/jest#11926), but unfortunately that means we can't really land this PR without breaking everybody using the matchers as asymmetric ones.

SimenB · 2021-10-06T07:53:01Z

We could tho, and just say that to use the asymmetric matchers you need to use Jest 27.x (whichever version it is when I make a release)?

/cc @rickhanlonii thoughts?

rickhanlonii · 2021-11-29T00:49:46Z

Could we release a new major of jest-extended instead?

SimenB · 2021-11-29T12:02:46Z

That's easiest, yeah 🙂

keeganwitt · 2022-01-13T01:03:04Z

Jest versions older than v27.2.5 fail because they lack the asymmetric matchers fix.

SimenB · 2022-01-25T12:53:17Z

Jest versions older than v27.2.5 fail because they lack the asymmetric matchers fix.

Yep, so we need to drop those versions from CI and update the peer dependency range before landing

keeganwitt · 2022-01-25T13:47:27Z

Replaced by #405 (because I'm no longer able to push to my fork after having deleted it).

keeganwitt mentioned this pull request Jul 1, 2021

Make Jest dependencies peer dependencies #331

Closed

4 tasks

SimenB approved these changes Jul 1, 2021

View reviewed changes

SimenB reviewed Jul 9, 2021

View reviewed changes

src/matchers/index.test.js Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

This was referenced Oct 6, 2021

fix: update dependencies #359

Merged

chore: migrate to named exports from rules #363

Merged

keeganwitt mentioned this pull request Oct 11, 2021

Don't invoke expect.extend #333

Merged

4 tasks

keeganwitt marked this pull request as draft January 6, 2022 07:09

SimenB mentioned this pull request Jan 12, 2022

Please upgrade the expect dependency to be in sync with other jest dependencies #399

Closed

keeganwitt marked this pull request as ready for review January 13, 2022 00:52

Delete expect and jest-matcher-utils dependencies

5491f54

keeganwitt mentioned this pull request Jan 18, 2022

fix(deps): update dependency expect to v27 - autoclosed #358

Closed

1 task

mattphillips approved these changes Jan 25, 2022

View reviewed changes

keeganwitt closed this Jan 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete expect and jest-matcher-utils dependencies #332

Delete expect and jest-matcher-utils dependencies #332

keeganwitt commented Jul 1, 2021 •

edited

Loading

SimenB left a comment •

edited

Loading

SimenB Jul 1, 2021 •

edited

Loading

keeganwitt Jul 1, 2021

SimenB commented Jul 1, 2021

keeganwitt commented Jul 1, 2021

SimenB commented Jul 2, 2021

keeganwitt commented Jul 3, 2021

SimenB left a comment

codecov bot commented Jul 9, 2021 •

edited

Loading

SimenB commented Aug 13, 2021

keeganwitt commented Aug 23, 2021

SimenB commented Oct 4, 2021

SimenB commented Oct 6, 2021

rickhanlonii commented Nov 29, 2021

SimenB commented Nov 29, 2021

keeganwitt commented Jan 13, 2022

SimenB commented Jan 25, 2022

keeganwitt commented Jan 25, 2022

	const failMessage = (received, after, context) => () =>
	const failMessage = (received, after, { matcherHint, printReceived }) => () =>

Delete expect and jest-matcher-utils dependencies #332

Delete expect and jest-matcher-utils dependencies #332

Conversation

keeganwitt commented Jul 1, 2021 • edited Loading

What

Why

Notes

Housekeeping

SimenB left a comment • edited Loading

Choose a reason for hiding this comment

SimenB Jul 1, 2021 • edited Loading

Choose a reason for hiding this comment

keeganwitt Jul 1, 2021

Choose a reason for hiding this comment

SimenB commented Jul 1, 2021

keeganwitt commented Jul 1, 2021

SimenB commented Jul 2, 2021

keeganwitt commented Jul 3, 2021

SimenB left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 9, 2021 • edited Loading

Codecov Report

SimenB commented Aug 13, 2021

keeganwitt commented Aug 23, 2021

SimenB commented Oct 4, 2021

SimenB commented Oct 6, 2021

rickhanlonii commented Nov 29, 2021

SimenB commented Nov 29, 2021

keeganwitt commented Jan 13, 2022

SimenB commented Jan 25, 2022

keeganwitt commented Jan 25, 2022

keeganwitt commented Jul 1, 2021 •

edited

Loading

SimenB left a comment •

edited

Loading

SimenB Jul 1, 2021 •

edited

Loading

codecov bot commented Jul 9, 2021 •

edited

Loading