fix: improve handling of .each calls and with tagged literals
#814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
refactor-each-handling
branch
from
e6f22fd
to
ede986c
Compare
G-Rath
force-pushed
the
refactor-each-handling
branch
from
ede986c
to
dd4d720
Compare
G-Rath
changed the title
.each calls and with tagged literals
G-Rath
force-pushed
the
refactor-each-handling
branch
from
b53917a
to
ac5872e
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2021
## [24.3.6](v24.3.5...v24.3.6) (2021-04-26) ### Bug Fixes * **no-conditional-expect:** check for expects in `catch`s on promises ([#819](#819)) ([1fee973](1fee973)) * **valid-expect:** support async `expect` in ternary statements ([#833](#833)) ([7b7a396](7b7a396)) * improve handling of `.each` calls and with tagged literals ([#814](#814)) ([040c605](040c605))
|
🎉 This PR is included in version 24.3.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the change described here, so that
isDescribeCallandisTestCaseCallnow returntruefor the outerCallExpressionin.each()()calls, meaning matched nodes are now consistent as it'll always be the top-most one.This has let us shed a bunch of edge-case code across our rules and utils, and also made it easy to refactor
no-focused-testsso that it's 1/3rd smaller 🎉Because of the mix of dependent and independent changes, I'm going to open this PR as a draft, and cherry pick some of the changes out into their own PRs.
Resolves #809
Resolves #810
Resolves #811