Fix ts as expression type error #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
commented
Aug 21, 2019
| Expression extends TSESTree.Expression = TSESTree.Expression | ||
| > extends TSESTree.TSTypeAssertion { | ||
| // expression: TypeAssertionChain<Expression> | Expression; | ||
| expression: any; // https://github.com/typescript-eslint/typescript-eslint/issues/802 |
There was a problem hiding this comment.
This is fixed in 2.0.0, so can be changed when we update.
There was a problem hiding this comment.
Cool. Just needs us to drop node 6 then.
|
🎉 This PR is included in version 22.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think our default stance on casts should be to just ignore them where possible, instead checking the node they're casting, for similar reason to why we don't bother w/
Boolean(<value>)There could of course be code where it's logical to take casts into account, but I think this is a sensible default.
As such, I added
expect(a.includes(b)).toEqual(0 as boolean);to reflect that.fixes #332