feat(valid-title): allow disabling titleMustBeString on test titles #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <[email protected]>
|
The danger failure is from 403's, so I think unrelated to my code changes. |
|
I think it might be a contributor thing? @SimenB would be the one to check - but had it been successful it would be reported that your PR does not have a description. |
G-Rath
added
rule: valid-title
enhancement
and removed
enhancement
rule: valid-title
labels
G-Rath
approved these changes
Oct 26, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
# [27.5.0](v27.4.3...v27.5.0) (2023-10-26) ### Features * **valid-title:** allow ignoring tests with non-string titles ([#1460](#1460)) ([ea89da9](ea89da9))
|
🎉 This PR is included in version 27.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I think d8b10b4 fixes the CI issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1234