Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't consider method calls on literals or new to be jest functions #1132

Merged
merged 1 commit into from
May 29, 2022
Merged

fix: don't consider method calls on literals or new to be jest functions #1132

merged 1 commit into from
May 29, 2022

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented May 29, 2022

I was trying to be a little clever, but there's a reason why getNodeName does this...

I've also included removing allowing NewExpression because that's also not correct.

Resolves #1128
Resolves #1130

@G-Rath G-Rath added the bug label May 29, 2022
@G-Rath
Copy link
Collaborator Author

G-Rath commented May 29, 2022

I've also just found we're matching on test.only``() - will fix that in another PR since it's a different thing

@G-Rath G-Rath merged commit 379ceb3 into main May 29, 2022
@G-Rath G-Rath deleted the fix-ref-checks branch May 29, 2022 19:33
github-actions bot pushed a commit that referenced this pull request May 29, 2022
@semantic-release-bot
chore(release): 26.4.3 [skip ci]
44de2ad 
## [26.4.3](v26.4.2...v26.4.3) (2022-05-29)

### Bug Fixes

* don't consider method calls on literals or `new` to be jest functions ([#1132](#1132)) ([379ceb3](379ceb3))
* produce valid code when when fixing properties accessed with square brackets ([#1131](#1131)) ([6cd600d](6cd600d))
@github-actions
Copy link

🎉 This PR is included in version 26.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@G-Rath G-Rath mentioned this pull request May 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@G-Rath