fix: proper support for it.each #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
approved these changes
Dec 11, 2020
Co-authored-by: Gareth Jones <[email protected]>
|
@k-yle is this still draft? |
|
sorry, it's ready @SimenB I thought someone else might try to make it work for this edge case: #710 (comment) but it seems to be very hard |
|
We can do that later 👍 |
G-Rath
approved these changes
Mar 6, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Mar 6, 2021
## [24.1.6](v24.1.5...v24.1.6) (2021-03-06) ### Bug Fixes * proper support for it.each ([#722](#722)) ([e1dc42d](e1dc42d))
|
🎉 This PR is included in version 24.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 6, 2021
This was referenced Mar 8, 2021
Closed
This was referenced Mar 11, 2021
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrying #701, this time without the regression for
no-done-callback🙊no-done-callbacknow works for jest-each's tagged-template syntax, but intentionally ignores it.each's table/array syntax because I have no idea how to handle this edge case.