Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofix for xdescribe.each is wrong #776

Closed
fabb opened this issue Mar 6, 2021 · 3 comments · Fixed by #780
Closed

Autofix for xdescribe.each is wrong #776

fabb opened this issue Mar 6, 2021 · 3 comments · Fixed by #780
Labels
bug each support Relates to supporting the `each` method released rule: no-disabled-tests rule: no-test-prefixes

Comments

@fabb
Copy link

fabb commented Mar 6, 2021

Autofix for xdescribe.each replaces by describe.each.skip which does not exist. It should be describe.skip.each.

https://jestjs.io/docs/uk/api#describeskipeachtablename-fn
@fabb
Copy link
Author

fabb commented Mar 6, 2021

And describe.skip.each does not trigger the rule jest/no-disabled-tests.

@G-Rath G-Rath mentioned this issue Mar 6, 2021
Merged
@G-Rath
Copy link
Collaborator

G-Rath commented Mar 6, 2021

The issue with no-test-prefixes has been fixed by #722

@G-Rath G-Rath mentioned this issue Mar 6, 2021
Merged
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

🎉 This issue has been resolved in version 24.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@G-Rath G-Rath added the each support Relates to supporting the `each` method label Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug each support Relates to supporting the `each` method released rule: no-disabled-tests rule: no-test-prefixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(no-test-prefixes): add case for xdescribe.each jest-community/eslint-plugin-jest
2 participants
@fabb @G-Rath