Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-restricted-matchers] New implementation using startsWith results in problems with selectors that match the beginning of another selecter #1235

Closed
cascornelissen opened this issue Sep 7, 2022 · 1 comment · Fixed by #1236
Closed

[no-restricted-matchers] New implementation using startsWith results in problems with selectors that match the beginning of another selecter #1235

cascornelissen opened this issue Sep 7, 2022 · 1 comment · Fixed by #1236
Assignees
@G-Rath
Labels
bug released rule: no-restricted-matchers

Comments

@cascornelissen
Copy link
Contributor

I feel like this change has unintended side effects. With the following item in the map we're also getting errors on toBeDefined, toBeUndefined, etc.

'toBe': "Use `toEqual()` instead.",

Originally posted by @cascornelissen in #1218 (comment)
@G-Rath G-Rath mentioned this issue Sep 7, 2022
Merged
@G-Rath G-Rath self-assigned this Sep 7, 2022
SimenB pushed a commit that referenced this issue Sep 8, 2022
@G-Rath
fix(no-restricted-matchers): improve check to not be solely based on …
5fe4568 
…the start of the matcher chain (#1236)

Resolves #1235
github-actions bot pushed a commit that referenced this issue Sep 8, 2022
@semantic-release-bot
chore(release): 27.0.2 [skip ci]
7fc648a 
## [27.0.2](v27.0.1...v27.0.2) (2022-09-08)

### Bug Fixes

* **no-restricted-matchers:** improve check to not be solely based on the start of the matcher chain ([#1236](#1236)) ([5fe4568](5fe4568)), closes [#1235](#1235)
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

🎉 This issue has been resolved in version 27.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-Rath G-Rath

Labels
bug released rule: no-restricted-matchers
Projects
None yet
Milestone
No milestone
2 participants
@cascornelissen @G-Rath