fix(no-test-callback): check argument is an identifier

jest-community · Jun 20, 2020 · f70612d · f70612d
1 parent e7e092a
commit f70612d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/rules/__tests__/no-test-callback.test.ts b/src/rules/__tests__/no-test-callback.test.ts
@@ -18,6 +18,16 @@ ruleTester.run('no-test-callback', rule, {
     'test("something", someArg)',
   ],
   invalid: [
+    {
+      code: 'test("something", (...args) => {args[0]();})',
+      errors: [
+        {
+          messageId: 'illegalTestCallback',
+          line: 1,
+          column: 20,
+        },
+      ],
+    },
     {
       code: 'test("something", done => {done();})',
       errors: [{ messageId: 'illegalTestCallback', line: 1, column: 19 }],

diff --git a/src/rules/no-test-callback.ts b/src/rules/no-test-callback.ts
@@ -34,6 +34,15 @@ export default createRule({
 
         const [argument] = callback.params;
 
+        if (argument.type !== AST_NODE_TYPES.Identifier) {
+          context.report({
+            node: argument,
+            messageId: 'illegalTestCallback',
+          });
+
+          return;
+        }
+
         if (callback.async) {
           context.report({
             node: argument,