fix(no-focused-tests): detect table format usage of .only.each

jest-community · Nov 30, 2019 · 0380bb3 · 0380bb3
1 parent ee23634
commit 0380bb3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/src/rules/__tests__/no-focused-tests.test.ts b/src/rules/__tests__/no-focused-tests.test.ts
@@ -34,6 +34,10 @@ ruleTester.run('no-focused-tests', rule, {
       code: 'describe.only.each()',
       errors: [{ messageId: 'focusedTest', column: 10, line: 1 }],
     },
+    {
+      code: 'describe.only.each`table`()',
+      errors: [{ messageId: 'focusedTest', column: 10, line: 1 }],
+    },
     {
       code: 'describe["only"]()',
       errors: [{ messageId: 'focusedTest', column: 10, line: 1 }],
@@ -46,6 +50,10 @@ ruleTester.run('no-focused-tests', rule, {
       code: 'it.only.each()',
       errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
     },
+    {
+      code: 'it.only.each`table`()',
+      errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
+    },
     {
       code: 'it["only"]()',
       errors: [{ messageId: 'focusedTest', column: 4, line: 1 }],
@@ -58,6 +66,10 @@ ruleTester.run('no-focused-tests', rule, {
       code: 'test.only.each()',
       errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],
     },
+    {
+      code: 'test.only.each`table`()',
+      errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],
+    },
     {
       code: 'test["only"]()',
       errors: [{ messageId: 'focusedTest', column: 6, line: 1 }],

diff --git a/src/rules/no-focused-tests.ts b/src/rules/no-focused-tests.ts
@@ -44,7 +44,10 @@ export default createRule({
   defaultOptions: [],
   create: context => ({
     CallExpression(node) {
-      const { callee } = node;
+      const callee =
+        node.callee.type === AST_NODE_TYPES.TaggedTemplateExpression
+          ? node.callee.tag
+          : node.callee;
 
       if (callee.type === AST_NODE_TYPES.MemberExpression) {
         if (
@@ -78,16 +81,6 @@ export default createRule({
       ) {
         context.report({ messageId: 'focusedTest', node: callee });
       }
-
-      if (
-        callee.type === AST_NODE_TYPES.TaggedTemplateExpression &&
-        callee.tag.type === AST_NODE_TYPES.MemberExpression &&
-        callee.tag.object &&
-        callee.tag.object.type === AST_NODE_TYPES.Identifier &&
-        isCallToFocusedTestFunction(callee.tag.object)
-      ) {
-        context.report({ messageId: 'focusedTest', node: callee });
-      }
     },
   }),
 });