Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Commit

Permalink
Exclude commons-codec and commons-io from assembled JAR
Browse files Browse the repository at this point in the history
Consumers of MXNet are exposed to the commons-codec and commons-io library versions MXNet uses internally. This change excludes those JARs from the JARs created with `make scalapkg`.

Alternative could be using the Maven Shade Plugin but that may be more hassle in the long term than its worth: https://maven.apache.org/plugins/maven-shade-plugin/
  • Loading branch information
Gordon Reid committed Jan 18, 2019
1 parent 61847be commit 0b141f7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions scala-package/assembly/src/main/assembly/assembly.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
<include>*:*:jar</include>
</includes>
<excludes>
<exclude>commons-codec:</exclude>
<exclude>commons-io:*</exclude>
<exclude>org.scala-lang:*</exclude>
<exclude>org.scala-lang.modules:*</exclude>
</excludes>
Expand Down

0 comments on commit 0b141f7

Please sign in to comment.