-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CocoaPods #12
Conversation
thanks so much @ricsantos ! 🙌 |
Looks good 👌 Actually, let's just wrap the whole thing in
Pushed an update to the
Thank you! 💯
Yep, I'll take care of that. 👌
Where is this documented? I tried this locally with Xcode 11.4.1 and I still needed
This is expected, so no worries.
Just merged a fix for this! |
When I tested the script in the console. Also using Xcode 11.4.1
(xcrun version 50.) |
@ricsantos ah, I was literally just testing this. 😄 Yes -- it looks like this only applies to |
i'll tag the new release + push to cocoapods soon |
thanks again for contributing @ricsantos! 🥇 sent you an invite to be a collaborator |
No worries, thanks for creating the project! So good to have the status bar set automatically! |
just realized i messed up the podspec here with my edits 😬 fixed in #16 |
🖤
As per your blog post, I have made a PR that adds support for CocoaPods.
Describe your changes
Added a
.podspec
file. It has an iOS deployment target added, but this is to ensure CocoaPods adds the source to your project. In order to make it compile for iOS, I wrapped most of the code inmain.swift
with a platform check#if os(OSX)
. I also chose Swift 5.0 instead of 5.2, hope that's ok.The readme was updated with CocoaPods instructions. The pod install instruction won't work until the pod is actually published to trunk.
For testing, I use the following:
as I found that the source wasn't copied in using the
:path =>
directive (not sure if I did something wrong here).The build script phase is similar to the SPM one:
Note I used
swift ... main.swift
instead ofswift run ... main.swift
as the former is deprecated.On first launch the simulator status bar seems not to update, but it does on subsequent launches.
The timezone is incorrect as per #10