Skip to content

Conversation

@stefanhaller
Copy link
Collaborator

Fixes keypad keys on some terminals like iTerm2 and Alacritty.

Fixes #5173

Arguably, tcell should take care of this, but as long as it doesn't, map them on
our side.
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 80dd6951
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (80dd695) Report Missing Report Missing Report Missing
Head commit (0d705dc) 59415 51739 87.08%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5185) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@stefanhaller
Copy link
Collaborator Author

This is now fixed upstream in tcell (see #5192), so we don't need this patch on our side any more. Closing.

@stefanhaller stefanhaller deleted the fix-keypad-keys branch January 11, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems with numpad usage in 0.58.0

2 participants