Skip to content

Conversation

patrick-5546
Copy link

@patrick-5546 patrick-5546 commented Sep 8, 2025

PR Description

Decrease minimum required git version to 2.30

It was previously updated to 2.32 here: #4718. Per its description, the version choice was arbitrary as long as it was at least 2.27.

The reason why I'm updating the version is that the server I remote into for work uses git v2.30.

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller
Copy link
Collaborator

I'm not a fan of this. Picking 2.32 wasn't completely arbitrary, it was a deliberate choice that allowed us to simplify our code by removing version-specific complexity. I don't want to revert this. Admittedly, the one change that is specific to 2.32 is not a big deal, but the changes for 2.31 are, and since we have more work to do in that area of the code, I don't want to make it more complex again.

I'd look into updating git on your server instead (2.30 is really, really old). If you don't have control over the server, installing it locally in your home directory is simple. Let me know if you need help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants