Run label check workflow only on label events and open pr event #4830

kyu08 · 2025-08-16T08:14:58Z

PR Description

Currently, check-required-label only runs when commits are added to a PR, even if a maintainer has added labels, so the CI status remains red until a commit is pushed after labels are added by a maintainer.
I updated the workflows to run check-required-label only on label events(add/remove) or open PR event.
This will make PR status updates more accurate, so authors will be able to see that tests and lint are passing by just checking the PR status, and maintainers will easily know if the PR is ready for review.

Test plan

I have tested that this workflow works as expected in my forked repo.

Please check if the PR fulfills these requirements

~~Cheatsheets are up-to-date (run go generate ./...)~~
~~Code has been formatted (see here)~~
~~Tests have been added/updated (see here for the integration test guide)~~
~~Text is internationalised (see here)~~
~~If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)~~
~~Docs have been updated if necessary~~
You've read through your own file changes for silly mistakes etc

stefanhaller

Thanks, this is a good change. It has annoyed me several times that I need to retrigger the label check manually after adding a label. I wasn't aware that it can be fixed like this.

Two small things below.

stefanhaller · 2025-08-17T15:07:30Z

.github/workflows/check-required-label.yml

+jobs:
+  check-required-label:
+    runs-on: ubuntu-latest
+    if: github.ref != 'refs/heads/master'


I think we can remove this condition; it was only needed in ci.yml because that one would also run on pushes to master.

Thanks for letting me know that.
Fixed by 63da5f7.

stefanhaller · 2025-08-17T15:12:23Z

.github/workflows/check-required-pr-label.yml


 on:
  pull_request:
    types: [opened, labeled, unlabeled]

 jobs:
-  check-required-label:
+  check-required-pr-label:


I'd rather drop this change (the other one is fine). This identifier is used in the repo config for which checks are required for merging, and I don't want Jesse to have to reconfigure anything there. (I don't have enough permissions to do that myself.)

I see!
Reverted on accbd7a.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | minor | `v0.54.2` -> `v0.55.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.55.0`](https://github.com/jesseduffield/lazygit/releases/tag/v0.55.0) [Compare Source](jesseduffield/lazygit@v0.54.2...v0.55.0)  #### What's Changed ##### Enhancements 🔥 - Allow filtering the keybindings menu by keybinding by [@stefanhaller](https://github.com/stefanhaller) in [#4821](jesseduffield/lazygit#4821) - Add support for suspending LazyGit with Ctrl+Z on Unix systems by [@cowboy8625](https://github.com/cowboy8625) in [#4757](jesseduffield/lazygit#4757) - Add "CopyToClipboard" command to `ConfirmationController` by [@kyu08](https://github.com/kyu08) in [#4810](jesseduffield/lazygit#4810) - Add a user config for using git's external diff command for paging by [@stefanhaller](https://github.com/stefanhaller) in [#4832](jesseduffield/lazygit#4832) - Log the hash of dropped stashes by [@stefanhaller](https://github.com/stefanhaller) in [#4850](jesseduffield/lazygit#4850) ##### Fixes 🔧 - Fix right-alignment of divergence from base branch for branch checked out in a worktree by [@stefanhaller](https://github.com/stefanhaller) in [#4824](jesseduffield/lazygit#4824) - Support Azure DevOps vs-ssh.visualstudio.com SSH remotes as hosting provider by [@Kahitar](https://github.com/Kahitar) in [#4822](jesseduffield/lazygit#4822) - Improve display of "esc" keybinding in the keybindings status bar by [@stefanhaller](https://github.com/stefanhaller) in [#4819](jesseduffield/lazygit#4819) - Use external diff command in stashes panel by [@stefanhaller](https://github.com/stefanhaller) in [#4836](jesseduffield/lazygit#4836) - Remove the git.paging.useConfig option by [@stefanhaller](https://github.com/stefanhaller) in [#4837](jesseduffield/lazygit#4837) - Don't auto-forward branches that are checked out in another worktree by [@stefanhaller](https://github.com/stefanhaller) in [#4833](jesseduffield/lazygit#4833) - Fix dropping range selection of filtered stashes by [@stefanhaller](https://github.com/stefanhaller) in [#4849](jesseduffield/lazygit#4849) - Fix rare crash in interactive rebase (merge command without comment) by [@stefanhaller](https://github.com/stefanhaller) in [#4872](jesseduffield/lazygit#4872) - Make it possible to rebind the Confirm keybinding by [@stefanhaller](https://github.com/stefanhaller) in [#4860](jesseduffield/lazygit#4860) ##### Maintenance ⚙️ - Pass only Git-tracked Go files to gofumpt by [@kyu08](https://github.com/kyu08) in [#4809](jesseduffield/lazygit#4809) - Update donation wording so that it's clear there's no strings attached by [@jesseduffield](https://github.com/jesseduffield) in [#4827](jesseduffield/lazygit#4827) - Enhance MR/Issue templates readability by [@kyu08](https://github.com/kyu08) in [#4829](jesseduffield/lazygit#4829) - Run label check workflow only on label events and open pr event by [@kyu08](https://github.com/kyu08) in [#4830](jesseduffield/lazygit#4830) ##### Docs 📖 - Add installation with gah by [@marverix](https://github.com/marverix) in [#4820](jesseduffield/lazygit#4820) - docs(VISION): fix "Dicoverability" typo by [@Rudxain](https://github.com/Rudxain) in [#4866](jesseduffield/lazygit#4866) - Add dev container feature as installation method to README by [@HenningLorenzen-ext-bayer](https://github.com/HenningLorenzen-ext-bayer) in [#4876](jesseduffield/lazygit#4876) ##### I18n 🌎 - Update translations from Crowdin by [@stefanhaller](https://github.com/stefanhaller) in [#4873](jesseduffield/lazygit#4873) #### New Contributors - [@marverix](https://github.com/marverix) made their first contribution in [#4820](jesseduffield/lazygit#4820) - [@Kahitar](https://github.com/Kahitar) made their first contribution in [#4822](jesseduffield/lazygit#4822) - [@cowboy8625](https://github.com/cowboy8625) made their first contribution in [#4757](jesseduffield/lazygit#4757) - [@Rudxain](https://github.com/Rudxain) made their first contribution in [#4866](jesseduffield/lazygit#4866) - [@HenningLorenzen-ext-bayer](https://github.com/HenningLorenzen-ext-bayer) made their first contribution in [#4876](jesseduffield/lazygit#4876) **Full Changelog**: <jesseduffield/lazygit@v0.54.2...v0.55.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Aug 17, 2025

stefanhaller reviewed Aug 17, 2025

View reviewed changes

kyu08 requested a review from stefanhaller August 18, 2025 00:43

Run label check workflow only on label events and open pr event

e932ea2

stefanhaller force-pushed the update-label-check branch from 63da5f7 to e932ea2 Compare August 18, 2025 05:40

stefanhaller added maintenance For refactorings, CI changes, tests, version bumping, etc and removed maintenance For refactorings, CI changes, tests, version bumping, etc labels Aug 18, 2025

stefanhaller merged commit 0f785c4 into jesseduffield:master Aug 18, 2025
13 of 14 checks passed

BrewTestBot mentioned this pull request Sep 6, 2025

lazygit 0.55.0 Homebrew/homebrew-core#236390

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Run label check workflow only on label events and open pr event #4830

Run label check workflow only on label events and open pr event #4830

Uh oh!

kyu08 commented Aug 16, 2025 •

edited

Loading

Uh oh!

stefanhaller left a comment

Uh oh!

stefanhaller Aug 17, 2025

Uh oh!

kyu08 Aug 17, 2025

Uh oh!

stefanhaller Aug 17, 2025

Uh oh!

kyu08 Aug 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Run label check workflow only on label events and open pr event #4830

Run label check workflow only on label events and open pr event #4830

Uh oh!

Conversation

kyu08 commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

Test plan

Please check if the PR fulfills these requirements

Uh oh!

stefanhaller left a comment

Choose a reason for hiding this comment

Uh oh!

stefanhaller Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

kyu08 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

stefanhaller Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

kyu08 Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kyu08 commented Aug 16, 2025 •

edited

Loading