Skip to content

Improve temp dir handling #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
+6 −4
Merged

Improve temp dir handling #4784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4afeed
Improve .gitignoring debug executables
stefanhaller Jul 30, 2025
6a17144
Don't exit after handling daemon mode
stefanhaller Jul 30, 2025
3a9dbf7
Create temp directories inside a "lazygit" folder rather than top-lev…
stefanhaller Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ test/git_server/data
test/_results/**

oryxBuildBinary
__debug_bin
__debug_bin*

.worktrees
demo/output/*
Expand Down
2 changes: 0 additions & 2 deletions pkg/app/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ func Handle(common *common.Common) {
if err := instruction.run(common); err != nil {
log.Fatal(err)
}

os.Exit(0)
}

func InDaemonMode() bool {
Expand Down
6 changes: 5 additions & 1 deletion pkg/app/entry_point.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@ func Start(buildInfo *BuildInfo, integrationTest integrationTypes.IntegrationTes
os.Exit(0)
}

tempDir, err := os.MkdirTemp("", "lazygit-*")
tmpDirBase := filepath.Join(os.TempDir(), "lazygit")
if err := os.MkdirAll(tmpDirBase, 0o700); err != nil {
log.Fatal(err.Error())
}
tempDir, err := os.MkdirTemp(tmpDirBase, "")
if err != nil {
log.Fatal(err.Error())
}
Expand Down