Skip to content

Conversation

jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented May 25, 2023

  • PR Description

See comments on #2668

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Uffizzi Preview deployment-26649 was deleted.

@stefanhaller
Copy link
Collaborator

Thanks for fixing these. It still needs an entry "hx": "helix", in the editorToPreset map though. (I would have pushed a fixup, but don't have time to check out the branch right now.)

@stefanhaller
Copy link
Collaborator

I pushed a fixup now. LGTM with that, thanks again!

And @dvic, sorry if my comments on #2668 came across as off-putting or nit-picky. I appreciate the contribution, thanks!

@jesseduffield
Copy link
Owner Author

Hmm I thought if I merged this to master locally and pushed master this PR would automatically close but it seams not. Alas

@stefanhaller stefanhaller deleted the fix-helix-editor branch May 26, 2023 05:53
@dvic
Copy link
Contributor

dvic commented May 26, 2023

I pushed a fixup now. LGTM with that, thanks again!

And @dvic, sorry if my comments on #2668 came across as off-putting or nit-picky. I appreciate the contribution, thanks!

No worries, thanks for taking the time to review PRs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants