Try to respect main branch in commits pannel #1397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjarkk
force-pushed
the
fix-1314-respect-main-branch
branch
from
c64f67b to
63e50e0
Compare
pkg/commands/loading_commits.go
Outdated
| @@ -312,14 +312,23 @@ func (c *CommitListBuilder) setCommitMergedStatuses(refName string, commits []*m | |||
| } | |||
|
|
|||
| func (c *CommitListBuilder) getMergeBase(refName string) (string, error) { | |||
| baseBranch := c.GitCommand.TryGetMainBranch() | |||
There was a problem hiding this comment.
I would benchmark how long it takes to run this function, because we could save some time by only running it once and storing the result on the git struct
There was a problem hiding this comment.
There are multiple structs that have something to do with git, i hope i picked a good one :)
mjarkk
force-pushed
the
fix-1314-respect-main-branch
branch
2 times, most recently
from
946297f to
cb6f3ac
Compare
mjarkk
force-pushed
the
fix-1314-respect-main-branch
branch
from
cb6f3ac to
3e64b78
Compare
|
This is superceded by #2619 so I'll close it off :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314
This should be a better way of detecting if commits are merged into the "main/master" branch