Spawned processes aren't killed

[M1kep]

Describe the bug
When launching processes via :, they don't seem to fully exit/terminate.

To Reproduce

1. Start lazygit
2. :
3. echo "cat"
4. :
5. <tab> Enter
6. q
7. ps aux | grep echo
8. See multiple unterminated processes

Expected behavior
Processes to exit when completed

Screenshots

Version info:
commit=, build date=, build source=homebrew, version=0.44.1, os=darwin, arch=arm64, git version=2.46.1
git version 2.46.1

Additional context
Add any other context about the problem here.

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

[stefanhaller]

I can't reproduce this, and I'm on Mac too, also using zsh.

But I suspect it has something to do with #3793, which is causing all sorts of problems for people (e.g. #3903 and #3923). We might just have to revert that PR for now.

Could you try a lazygit version before 0.44.0; do you also see the unterminated processes with that?

[M1kep]

0.43.1 seems to fix the issue, though as expected also breaks the usage of aliases, which I can work around, albeit with uglier commands