Use proper rounding name

jessealama · May 7, 2024 · 02c0f5a · 02c0f5a
1 parent 5ead135
commit 02c0f5a
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 4 deletions.
diff --git a/src/decimal128.mts b/src/decimal128.mts
@@ -460,8 +460,6 @@ function adjustNonInteger(
     options: FullySpecifiedConstructorOptions
 ): SignedSignificandExponent {
     switch (options.roundingMode) {
-        case ROUNDING_MODE_HALF_EVEN:
-            return roundHalfEven(x);
         case ROUNDING_MODE_CEILING:
             return roundCeiling(x);
         case ROUNDING_MODE_FLOOR:

diff --git a/tests/constructor.test.js b/tests/constructor.test.js
@@ -466,7 +466,7 @@ describe("rounding options", () => {
             roundTowardNegative: "-1234567890123456789012345678901235",
             roundTowardZero: "-1234567890123456789012345678901234",
             roundTiesToEven: "-1234567890123456789012345678901234",
-            roundTiesAway: "-1234567890123456789012345678901234",
+            roundTiesToAway: "-1234567890123456789012345678901235",
         };
         for (const [mode, expected] of Object.entries(answers)) {
             test(`constructor with rounding mode "${mode}"`, () => {
@@ -483,7 +483,7 @@ describe("rounding options", () => {
             roundTowardNegative: "-1234567890123456789012345678901240",
             roundTowardZero: "-1234567890123456789012345678901239",
             roundTiesToEven: "-1234567890123456789012345678901240",
-            roundTiesAway: "-1234567890123456789012345678901240",
+            roundTiesToAway: "-1234567890123456789012345678901240",
         };
         for (const [mode, expected] of Object.entries(roundUpAnswers)) {
             test(`constructor with rounding mode "${mode}"`, () => {

diff --git a/tests/round.test.js b/tests/round.test.js
@@ -166,6 +166,33 @@ describe("Intl.NumberFormat examples", () => {
             ).toStrictEqual("1");
         });
     });
+    describe("halfExpand", () => {
+        test("-1.5", () => {
+            expect(
+                minusOnePointFive.round(0, "roundTiesToAway").toString()
+            ).toStrictEqual("-2");
+        });
+        test("0.4", () => {
+            expect(
+                zeroPointFour.round(0, "roundTiesToAway").toString()
+            ).toStrictEqual("0");
+        });
+        test("0.5", () => {
+            expect(
+                zeroPointFive.round(0, "roundTiesToAway").toString()
+            ).toStrictEqual("1");
+        });
+        test("0.6", () => {
+            expect(
+                zeroPointSix.round(0, "roundTiesToAway").toString()
+            ).toStrictEqual("1");
+        });
+        test("1.5", () => {
+            expect(
+                onePointFive.round(0, "roundTiesToAway").toString()
+            ).toStrictEqual("2");
+        });
+    });
     describe("halfEven", () => {
         test("-1.5", () => {
             expect(