-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repackage existing tool to be pip-installable #92
Open
digitalsleuth
wants to merge
44
commits into
jesparza:master
Choose a base branch
from
digitalsleuth:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool can now be installed using pip install git+. Also changed where the error file is placed and how it is named.
Additionally, removed the aespython, colorama, and jsbeautifier folders as these are now pip installable as well (and get installed with the setup.py). Remainder of the tool remains in-tact.
Originally tried fooling with upgrading the tool to python3 and got most of the way there. When time became a factor after I hit an encoding snag, I reverted back to the original tool.
Upgraded the version to 0.3.8 as well (vice 0.3 r275) just to reflect the layout change and minor changes.
Please reach out if you have any questions. Lenny can give you my contact info.