Fix error handling in scanner in case of OOM

[rerobika]

This patch fixes #3786 and fixes #3788.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik [email protected]

[dbatyai]

LGTM

[zherczeg]

I would like to understand what is happening here exactly.

[rerobika]

The patch is updated. The related testcases in the issues cannot be added since there is no way to ensure that the OOM happens in the scanner not elsewhere in the engine.

[zherczeg]

Much better. Just a few things.

[rerobika]

@zherczeg Thanks for the review, the PR is updated.

[zherczeg]

I have been thinking about an alternative for this patch, which does not require a separate free function.

It would look like this:

PARSER_CATCH
{
  while (scanner_context.active_binding_list_p != NULL) ...

  if (JERRY_LIKELY (context_p->error != PARSER_ERR_OUT_OF_MEMORY))
  {
    context_p->error = PARSER_ERR_NO_ERROR;

    PARSER_TRY (context_p->try_buffer)
    {
      ...
    }
    PARSER_CATCH
    {
      JERRY_ASSERT (context_p->error == PARSER_ERR_OUT_OF_MEMORY);
    }
  }

  JERRY_ASSERT (context_p->error == PARSER_ERR_NO_ERROR || context_p->error == PARSER_ERR_OUT_OF_MEMORY);

  if (JERRY_UNLIKELY (context_p->error == PARSER_ERR_OUT_OF_MEMORY))
  {
      release...
      parser_stack_free (context_p);
      return;
  }
}

What do you think? I can do it in a separate patch if you wish.

[rerobika]

+1 for the separate patch!

[rerobika]

@zherczeg I've updated the PR with the suggested code above.

[zherczeg]

LGTM
Much better!