Skip to content

Conversation

galpeter
Copy link
Contributor

@galpeter galpeter commented Aug 1, 2019

No description provided.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
@rerobika
Copy link
Member

rerobika commented Aug 1, 2019

I think the expected result buffer in the snapshot related unittest file should be updated as well.

@galpeter
Copy link
Contributor Author

galpeter commented Aug 1, 2019

@rerobika the snapshot has its own version number which is not changed.

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 27da5a5 into jerryscript-project:master Aug 1, 2019
@LaszloLango LaszloLango added this to the Release 2.0 milestone Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants