Support for rfc3164 variants which lack the host name #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2016 14:32
This field was added in 72655c1c2bb3 ("Add support for local timezones in
RFC3164 parsing") but this was not reflected in the test suite.
Signed-off-by: Ian Campbell <[email protected]>
The busybox syslogd does this when logging over the network. This cannot be autodetected, but allow a caller which is aware it is dealing with this format to prepopulate a hostname and skip that token when parsing. Adjust the toplevel Parse to only skip a character after parseHeader if it is a space, since parseHostname now does not always skip to the next space. Signed-off-by: Ian Campbell <[email protected]>
|
Thanks for the patch. Sorry for being so late I did not receive any notification for your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The busybox syslogd produces syslog messages like this:
because it forwards the
/dev/logdatagram as is and this does not include the hostname field.To support this case I have added a method to set the hostname the parser should use which can then be called before parsing. The idea being that the caller can know something like this by looking at the incoming network connection (and perhaps doing a reverse DNS lookup). I think this is what the comment in the busybox code is sort of implying (i.e. the hostname could be a lie, so the receiver should probably make up their own mind)
Perhaps this really ought to be a new (
rfc3164busybox?rfc3164devlog?) package, but that seems like an awful lot of code duplication for such a simple change.The first patch fixes up the test suite, I also added a new test case to cover the new behaviour. Everything passes for me.