Skip to content

Commit

Permalink
Bump msal-node-extensions in @azure/identity-cache-persistence (Azure…
Browse files Browse the repository at this point in the history
…#27961)

### Packages impacted by this PR
- @azure/identity-cache-persistence

### Issues associated with this PR


### Describe the problem that is addressed by this PR
@azure/identity-cache-persistence uses and older (1.0.0-alpha.25) of
@azure/msal-node-extension which does not come with pre built native
binaries. Therefore, it requires python to be installed on the consumers
machine to be able to build binaries.

The newer version of @azure/msal-node-extension 1.0.8, which supports
node 16, comes with native binaries.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

- Bumping @azure/msal-node-extension in
@azure/identity-cache-persistence so that consumers do not need to have
python installed for node-gyp to be able to consume
@azure/msal-node-extension

### Are there test cases added in this PR? _(If not, why?)_

No need, just run existing tests.

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
  • Loading branch information
altinokdarici authored Dec 6, 2023
1 parent 02491d7 commit 9b54a83
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 24 deletions.
32 changes: 9 additions & 23 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/identity/identity-cache-persistence/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@azure/core-auth": "^1.5.0",
"@azure/identity": "^4.0.0",
"@azure/msal-node": "^2.5.1",
"@azure/msal-node-extensions": "1.0.0-alpha.25",
"@azure/msal-node-extensions": "1.0.8",
"keytar": "^7.6.0",
"tslib": "^2.2.0"
},
Expand Down

0 comments on commit 9b54a83

Please sign in to comment.