fix(shulker-proxy-agent): crash when LoadBalancer service does not have any ingress in status #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylvln
added
type:bug 🐛
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 31.69% 31.69%
=======================================
Files 58 58
Lines 3124 3124
=======================================
Hits 990 990
Misses 2134 2134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jeremylvln
force-pushed
the
fix/proxy-crash-lb-service
branch
from
1954aeb to
0bb929f
Compare
jeremylvln
pushed a commit
that referenced
this pull request
Aug 25, 2024
## [0.10.0](v0.9.0...v0.10.0) (2024-08-25) ### ✨ Features ✨ * **shulker-proxy-agent:** expose player teleporting in API ([#629](#629)) ([111ca37](111ca37)) * support providing external servers ([#631](#631)) ([86b4804](86b4804)) ### 🐛 Bug Fixes 🐛 * **shulker-proxy-agent:** crash when LoadBalancer service does not have any ingress in status ([#627](#627)) ([8be044a](8be044a)) * **shulker-proxy-agent:** do not watch service if preferred address is provided ([a8e2e70](a8e2e70))
|
🎉 This issue has been resolved in version 0.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, now watch the Service's updates, so the external IP is updated directly without any restart.
Closes #626