feat: support reconnecting players to cluster #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 31.53% 31.68% +0.14%
==========================================
Files 58 58
Lines 3117 3125 +8
==========================================
+ Hits 983 990 +7
- Misses 2134 2135 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rc/common/kotlin/io/shulkermc/proxyagent/adapters/kubernetes/ImplKubernetesGatewayAdapter.kt
Fixed
Show fixed
Hide fixed
|
One thing that would be nice is to have some sort of way to override the IP/Hostname it will transfer the users to. In my planned usage case I intend to be running on bare metal and utilizing an external DDoS protection provider (i.e TCPShield) which would require me to re-route the players to a specific hostname. |
This would be a nice addition, indeed! |
|
What implications would this have for Minigame Servers? Would all players be reconnected and sent to the Lobby while in-game? |
jeremylvln
force-pushed
the
feat/transfer-player
branch
from
d9b2141 to
ca6257a
Compare
jeremylvln
force-pushed
the
feat/transfer-player
branch
2 times, most recently
from
94ef4ba to
7166891
Compare
...lker-proxy-agent/src/common/kotlin/io/shulkermc/proxyagent/services/ProxyLifecycleService.kt
Fixed
Show fixed
Hide fixed
...lker-proxy-agent/src/common/kotlin/io/shulkermc/proxyagent/services/ProxyLifecycleService.kt
Fixed
Show fixed
Hide fixed
...lker-proxy-agent/src/common/kotlin/io/shulkermc/proxyagent/services/ProxyLifecycleService.kt
Fixed
Show fixed
Hide fixed
...lker-proxy-agent/src/common/kotlin/io/shulkermc/proxyagent/services/ProxyLifecycleService.kt
Fixed
Show fixed
Hide fixed
...lker-proxy-agent/src/common/kotlin/io/shulkermc/proxyagent/services/ProxyLifecycleService.kt
Fixed
Show fixed
Hide fixed
...lker-proxy-agent/src/common/kotlin/io/shulkermc/proxyagent/services/ProxyLifecycleService.kt
Fixed
Show fixed
Hide fixed
jeremylvln
force-pushed
the
feat/transfer-player
branch
from
7166891 to
ca9b7ba
Compare
jeremylvln
force-pushed
the
feat/transfer-player
branch
from
ca9b7ba to
9fb9e64
Compare
jeremylvln
pushed a commit
that referenced
this pull request
Aug 24, 2024
## [0.9.0](v0.8.1...v0.9.0) (2024-08-24) ### ⚠ BREAKING CHANGES * upgrade all workspace (#618) ### ✨ Features ✨ * **shulker-crds:** specify scale subresource for ProxyFleet and MinecraftServerFleet ([#623](#623)) ([569e010](569e010)) * support reconnecting players to cluster ([#364](#364)) ([1a2266e](1a2266e)) * upgrade all workspace ([#618](#618)) ([6a34b62](6a34b62)) ### 🐛 Bug Fixes 🐛 * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.38.0 ([#545](#545)) ([d5e1ad0](d5e1ad0)) * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.39.0 ([#547](#547)) ([d786cb6](d786cb6)) * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.39.1 ([#561](#561)) ([b0745b4](b0745b4)) * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.40.0 ([#580](#580)) ([469fb17](469fb17)) * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.42.0 ([#620](#620)) ([f13cd98](f13cd98)) * **deps:** update dependency com.google.guava:guava to v33.1.0-jre ([#500](#500)) ([d865881](d865881)) * **deps:** update dependency com.google.guava:guava to v33.2.0-jre ([#546](#546)) ([bfbb4aa](bfbb4aa)) * **deps:** update dependency com.google.guava:guava to v33.2.1-android ([#577](#577)) ([c0858d9](c0858d9)) * **deps:** update dependency com.google.guava:guava to v33.2.1-jre ([#578](#578)) ([2a3a7b9](2a3a7b9)) * **deps:** update dependency com.google.protobuf:protobuf-java to v3.25.4 ([#619](#619)) ([266a85e](266a85e)) * **deps:** update dependency net.kyori:adventure-api to v4.17.0 ([#556](#556)) ([52e3b0e](52e3b0e)) * **deps:** update dependency net.kyori:adventure-platform-bungeecord to v4.3.3 ([#582](#582)) ([05e3471](05e3471)) * **deps:** update dependency redis.clients:jedis to v5.1.3 ([#568](#568)) ([90745de](90745de)) * **deps:** update fabric8-kubernetes-client monorepo to v6.12.1 ([#548](#548)) ([dfc3b98](dfc3b98)) * **deps:** update fabric8-kubernetes-client monorepo to v6.13.0 ([#576](#576)) ([a9a13d7](a9a13d7)) * **deps:** update grpc-java monorepo to v1.63.0 ([#549](#549)) ([c45fea4](c45fea4)) * **deps:** update grpc-java monorepo to v1.64.0 ([#560](#560)) ([f714fe1](f714fe1)) ### 📚 Documentation 📚 * add search ([#616](#616)) ([9a6813b](9a6813b)) * change "Mounting volumes" example text ([#526](#526)) ([f271222](f271222)) * fix Mincraft typo ([#527](#527)) ([875de67](875de67))
|
🎉 This issue has been resolved in version 0.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new transfer packets, we can now finish properly the proxy drain feature by reconnecting the players automatically when the TTL is expired.
Also, expose the method in the API if custom plugins want to re-use this capability.