Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shulker-proxy-agent): use proxy capacities as max slots in ping requests #394

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

jeremylvln
Copy link
Owner

@jeremylvln jeremylvln commented Feb 6, 2024

The capacities are stored in Redis alongside other metadata. The total available slots of the cluster is the sum of each capacity. This allows having different fleets with different capacities and still having an accurate number on ping requests.

Closes #393

@jeremylvln jeremylvln force-pushed the feat/393-ping-with-proxy-capacities branch from 1924e36 to 31cd569 Compare February 6, 2024 10:33
@jeremylvln jeremylvln marked this pull request as ready for review February 6, 2024 10:33
@jeremylvln jeremylvln enabled auto-merge (squash) February 6, 2024 13:42
@jeremylvln jeremylvln force-pushed the feat/393-ping-with-proxy-capacities branch from 2043580 to 6ea4ec1 Compare February 6, 2024 13:47
@jeremylvln jeremylvln merged commit 235e6ba into main Feb 6, 2024
7 checks passed
@jeremylvln jeremylvln deleted the feat/393-ping-with-proxy-capacities branch February 6, 2024 13:54
jeremylvln pushed a commit that referenced this pull request Feb 6, 2024
## [0.7.0](v0.6.1...v0.7.0) (2024-02-06)

### ✨ Features ✨

* exclude proxy from load balancer when full ([#396](#396)) ([e53e9f3](e53e9f3))
* **shulker-proxy-agent:** use proxy capacities as max slots in ping requests ([#394](#394)) ([235e6ba](235e6ba))

### 🐛 Bug Fixes 🐛

* **deps:** update dependency net.md-5:bungeecord-api to v1.20-r0.2 ([#386](#386)) ([7d96f9b](7d96f9b))
* **shulker-operator:** bump proxy image to fix motd parsing error ([#397](#397)) ([35437b2](35437b2))
Copy link

github-actions bot commented Feb 6, 2024

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

TropicalShadow pushed a commit to BridgeSplash/Shulker that referenced this pull request Feb 6, 2024
## [1.1.0](v1.0.12...v1.1.0) (2024-02-06)

### ✨ Features ✨

* exclude proxy from load balancer when full ([jeremylvln#396](https://github.com/bridgesplash/Shulker/issues/396)) ([e53e9f3](e53e9f3))
* **shulker-proxy-agent:** use proxy capacities as max slots in ping requests ([jeremylvln#394](https://github.com/bridgesplash/Shulker/issues/394)) ([235e6ba](235e6ba))

### 🐛 Bug Fixes 🐛

* **shulker-operator:** bump proxy image to fix motd parsing error ([jeremylvln#397](https://github.com/bridgesplash/Shulker/issues/397)) ([35437b2](35437b2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ping max players to take into account each proxy capacity
1 participant