Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ping max players to take into account each proxy capacity #393

Closed
jeremylvln opened this issue Feb 6, 2024 Discussed in #388 · 1 comment · Fixed by #394
Closed

Change ping max players to take into account each proxy capacity #393

jeremylvln opened this issue Feb 6, 2024 Discussed in #388 · 1 comment · Fixed by #394
Assignees
Labels
type:enhancement 🚀 New feature or request

Comments

@jeremylvln
Copy link
Owner

jeremylvln commented Feb 6, 2024

The idea is to change the algorithm that patch the ping statistics of the proxies. Currently, the max player count is the max capacity of the proxy that was ping, however, we would prefer to have a sum of each proxy's capacity.

It could be nice to have to be able to customize further the strategy with some configuration, but it seems unneeded for now.


Discussed in #388

Originally posted by TropicalShadow February 4, 2024

display the max player count for the proxy as the max cluster player count.

The online player count dynamically scales to the cluster wide online count, however the max player count is the proxy configured player capacity.

It would ideally be better to somehow poll all the proxies and or sub servers then calculate the total max players based on each server capacity and how many server/proxies available (not draining).

maybe have a config to determine the strategy of calculating max player count. Proxy only, all proxies, sub servers.

  • proxy only: default how it works now where it uses the proxy config
  • All proxies: calculates the max for each proxy adding them all up
  • Sub servers: calculate all the sub servers, adding up the max player capacity for all
Copy link

github-actions bot commented Feb 6, 2024

🎉 This issue has been resolved in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant