Mirror: feat(mcp): re-enable oauth resource parameter and add discovery logging (#5331) #10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,12 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "npm" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| open-pull-requests-limit: 5 | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| open-pull-requests-limit: 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: CodeQL | ||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| security-events: write | ||
| contents: read | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: Analyze | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| language: [javascript-typescript] | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v3 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| - name: Autobuild | ||
| uses: github/codeql-action/autobuild@v3 | ||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| name: PR Agent | ||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, ready_for_review] | ||
| issue_comment: | ||
| types: [created] | ||
|
|
||
| permissions: | ||
| issues: write | ||
| pull-requests: write | ||
| contents: read | ||
|
|
||
| jobs: | ||
| pr_agent: | ||
| if: ${{ github.event.sender.type != 'Bot' }} | ||
| runs-on: ubuntu-latest | ||
| name: Run PR Agent | ||
| steps: | ||
| - name: PR Agent action step | ||
| id: pragent | ||
| uses: qodo-ai/pr-agent@main | ||
| env: | ||
| OPENAI_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| { | ||
| "commentTypes": ["logic", "syntax", "style"], | ||
| "strictness": 1, | ||
| "fixWithAI": true, | ||
| "triggerOnUpdates": true, | ||
| "summarySection": { | ||
| "included": true, | ||
| "collapsible": false, | ||
| "defaultOpen": true | ||
| }, | ||
| "issuesTableSection": { | ||
| "included": true, | ||
| "collapsible": false, | ||
| "defaultOpen": true | ||
| }, | ||
| "confidenceScoreSection": { | ||
| "included": true, | ||
| "collapsible": false, | ||
| "defaultOpen": true | ||
| }, | ||
| "sequenceDiagramSection": { | ||
| "included": true, | ||
| "collapsible": true, | ||
| "defaultOpen": false | ||
| }, | ||
| "ignorePatterns": [ | ||
| "*.lock", | ||
| "*.snap", | ||
| "pnpm-lock.yaml", | ||
| "src/i18n/locales/**" | ||
| ], | ||
| "customContext": [ | ||
| { | ||
| "type": "rules", | ||
| "value": "This is a pnpm monorepo using Turbo. Packages: src/ (VSCode extension), webview-ui/ (React frontend), cli/ (CLI), packages/ (shared types, ipc, telemetry), jetbrains/ (Kotlin plugin), apps/ (docs, e2e, storybook)." | ||
| }, | ||
| { | ||
| "type": "rules", | ||
| "value": "All code changes that modify Kilo Code behavior MUST include kilocode_change markers in comments explaining what was changed and why." | ||
| }, | ||
| { | ||
| "type": "rules", | ||
| "value": "PRs that touch UI or settings MUST include i18n translation strings. A GUI-based change with settings typically involves 12-13 files plus ~18 more for i18n." | ||
| }, | ||
| { | ||
| "type": "rules", | ||
| "value": "PRs SHOULD include a .changeset/ file for version bumping. Exception: docs-only changes in apps/kilocode-docs/ do not require changesets." | ||
| }, | ||
| { | ||
| "type": "rules", | ||
| "value": "New provider additions follow a pattern: handler in src/api/providers/, model info, types in packages/types/, i18n strings, and tests. Check existing providers like anthropic or openai for the pattern." | ||
| }, | ||
| { | ||
| "type": "rules", | ||
| "value": "TypeScript strict mode. No any types without justification. Use Zod schemas for runtime validation at system boundaries." | ||
| }, | ||
| { | ||
| "type": "rules", | ||
| "value": "Security: No hardcoded credentials, API keys, or secrets. Validate all user inputs. No command injection in ExecuteCommand tool. No XSS in webview-ui." | ||
| }, | ||
| { | ||
| "type": "rules", | ||
| "value": "Test expectations: Unit tests for business logic, integration tests for API handlers, e2e tests for critical user flows. Tests live alongside source files or in __tests__ directories." | ||
| }, | ||
| { | ||
| "type": "files", | ||
| "path": "AGENTS.md", | ||
| "description": "Project structure, architecture overview, agent runtime details, and coding conventions" | ||
| }, | ||
| { | ||
| "type": "files", | ||
| "path": "CONTRIBUTING.md", | ||
| "description": "Contribution guidelines, PR requirements, commit message format" | ||
| }, | ||
| { | ||
| "type": "files", | ||
| "path": ".github/pull_request_template.md", | ||
| "description": "Expected PR format: Context, Implementation, Screenshots, How to Test" | ||
| }, | ||
| { | ||
| "type": "other", | ||
| "value": "This repo has 50+ AI provider integrations. When reviewing provider changes, check for: correct error handling, proper streaming support, model capability declarations, and consistent patterns with existing providers." | ||
| }, | ||
| { | ||
| "type": "other", | ||
| "value": "The docs site is a Next.js app using Markdoc at apps/kilocode-docs/. Docs PRs only need Build Markdoc Site and check-translations CI checks to pass." | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -194,7 +194,7 @@ export class McpOAuthService { | |
| state, | ||
| codeChallenge, | ||
| codeChallengeMethod: "S256", | ||
| resource: serverUrl, | ||
|
There was a problem hiding this comment. Re-enabling the
|
||
| }) | ||
|
|
||
| // 5. Verify State | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the addition of
console.warn, the error is no longer fully ignored. To avoid confusion, it would be clearer to update the comment to reflect that the error is logged before proceeding.