Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to Laravel 9 #176

Merged
merged 6 commits into from
Feb 17, 2022
Merged

Conversation

rafaelqm
Copy link
Contributor

Adding support

@jeremykenedy jeremykenedy merged commit f16effc into jeremykenedy:master Feb 17, 2022
@daniel-omnistock
Copy link

daniel-omnistock commented Feb 18, 2022

@rafaelqm @jeremykenedy

This PR added the requirement to manually add a non-public repository to your composer.json to be able to install a dev- version of a package. I do not know why this version is necessary but I think this procedure is really undesirable.

So if it really is necessary I suggest we wait for a stable version of the package and include it then. Otherwise just remove the dependency please.

@rafaelqm
Copy link
Contributor Author

@rafaelqm @jeremykenedy

This PR added the requirement to manually add a non-public repository to your composer.json to be able to install a dev- version of a package. I do not know why this version is necessary but I think this procedure is really undesirable.

So if it really is necessary I suggest we wait for a stable version of the package and include it then. Otherwise just remove the dependency please.

Hi @daniel-omnistock , I just added the vcs pointing to my repo because the eklundkristoffer/seedster requires Laravel 8, and I've also send a PR to them to be able use the illuminate/support 9 eklundkristoffer/seedster#6.
I think that after they accepting my PR it won't be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants