Skip to content

Conversation

@denydias
Copy link
Contributor

@denydias denydias commented Oct 19, 2021

Laravel Activity Logger already provide almost complete localization support. There's only one area where localization couldn't happen: event listener activities ('logged in', 'logged out' and such). This PR is an attempt to provide this missing functionality to such a great package.

@denydias
Copy link
Contributor Author

Scrutinizer failed, but I don't think it's related to the proposed PR:

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399
PHP Stack trace:
PHP   1. {main}() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Autoload::load($class = 'PHP_CodeSniffer\\Config') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Runner.php:67
PHP   4. PHP_CodeSniffer\Autoload::loadFile($path = '/home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/autoload.php:134

@jeremykenedy jeremykenedy merged commit a4996f7 into jeremykenedy:master Nov 25, 2021
@jeremykenedy
Copy link
Owner

Thank you

@denydias
Copy link
Contributor Author

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants