Add support for custom Activity model #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same Scrutinizer issue as PR #110, appear not related to this commit. StyleCI and Travis went fine tho. |
jeremykenedy
approved these changes
Nov 17, 2020
|
Thank you so much for merging this, @jeremykenedy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re. #94 this PR add the ability to customize default Activity model.
As per @jeremykenedy demands in the referred issue:
It was developed in Laravel 5.8 and tested up to Laravel 8. It should work all the way down to Laravel 5.1 tho.
Unable to comply as there's the need to choose the desired Activity model with
Done.
I hope this PR find its way to master. Thanks again for the great package, @jeremykenedy.