Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Commonmarker v1 api #10

Merged
merged 9 commits into from
Jan 5, 2024

Conversation

unasuke
Copy link
Contributor

@unasuke unasuke commented Dec 31, 2023

What

retry of rtomayko/tilt#396

The Commonmarker gem released v1 incluging breaking api changes.
https://github.com/gjtorikian/commonmarker/releases/tag/v1.0.0

These changes supports the new commonmarker's api.

To support commonmaker's breaking api changes, tilt gem will release new version including incompatible api change also.
For notice to tilt gem user, is it better to check commonmarker gem's version?

... and support both of CommonMaker (0.x) and Commonmarker (1.0.x)

Copy link
Owner

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. This is a great start. Please see requested changes. Also, I've enabled CI so you can see where the CI failures are.

.ci.gemfile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
test/tilt_commonmarkertemplate_test.rb Outdated Show resolved Hide resolved
lib/tilt/commonmarker.rb Outdated Show resolved Hide resolved
@unasuke
Copy link
Contributor Author

unasuke commented Jan 5, 2024

I made some commits above older changesets for review. I think it's better to squash before it merges.

@jeremyevans
Copy link
Owner

Looks good, thank you for making the changes. I'll squash merge this assuming CI passes.

@jeremyevans
Copy link
Owner

jeremyevans commented Jan 5, 2024

Looks like a couple spec fixes are needed to pass on Ruby 2.1 and 2.0. Just switch to a regular heredoc (<< instead of <<~) and do not indent, that should fix it.

for ruby 2.1 or older
@unasuke
Copy link
Contributor Author

unasuke commented Jan 5, 2024

Fixed at 290541d !

@jeremyevans jeremyevans merged commit 63a7c27 into jeremyevans:master Jan 5, 2024
15 checks passed
@jeremyevans
Copy link
Owner

Thank you very much for your work on this!

@unasuke
Copy link
Contributor Author

unasuke commented Jan 5, 2024

@jeremyevans Thank you too, I'm glad if rtomayko/tilt#395 is merged also.

@unasuke unasuke deleted the commonmarker-v1 branch January 5, 2024 20:06
@jeremyevans
Copy link
Owner

The gem homepage was fixed. I agree that it would be best the old repository README was updated, but I have no control over that I would not expect it at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants