-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Commonmarker v1 api #10
Conversation
The Commonmarker gem released v1 incluging breaking api changes. https://github.com/gjtorikian/commonmarker/releases/tag/v1.0.0 These changes supports the new commonmarker's api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. This is a great start. Please see requested changes. Also, I've enabled CI so you can see where the CI failures are.
I made some commits above older changesets for review. I think it's better to squash before it merges. |
Looks good, thank you for making the changes. I'll squash merge this assuming CI passes. |
Looks like a couple spec fixes are needed to pass on Ruby 2.1 and 2.0. Just switch to a regular heredoc ( |
for ruby 2.1 or older
Fixed at 290541d ! |
Thank you very much for your work on this! |
@jeremyevans Thank you too, I'm glad if rtomayko/tilt#395 is merged also. |
The gem homepage was fixed. I agree that it would be best the old repository README was updated, but I have no control over that I would not expect it at this point. |
What
retry of rtomayko/tilt#396
... and support both of
CommonMaker
(0.x) andCommonmarker
(1.0.x)