[#171] [DRAFT] Upgrade to [email protected] #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jeremyckahn/farmhand/CbV4yKBBnUAaEj7zAxbCvxZVXU3S |
lstebner
reviewed
Aug 15, 2021
| @@ -76,7 +76,7 @@ | |||
| "axios": "^0.21.1", | |||
| "classnames": "^2.2.6", | |||
| "compass-mixins": "^0.12.10", | |||
| "dinero.js": "^1.7.0", | |||
| "dinero.js": "2.0.0-alpha.8", | |||
There was a problem hiding this comment.
i think we probably don't want to merge without a stable version here
There was a problem hiding this comment.
Definitely! This will be upgraded to a stable version before this gets promoted to a proper PR that's ready for review. Check out #171 (comment) for the full context for this PR!
|
This change doesn't appear to be needed, so I'm closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
It upgrades Dinero.js to 2.0.0. Currently the discussion for this change is happening in #171. This PR and description will be updated once dinerojs/dinero.js#309 is merged.
This PR should be considered a work in progress and does not yet need a formal review.
How this change can be validated
Questions or concerns about this change
Additional information