Allow more comparisons #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZXShady
force-pushed
the
more_comparisons
branch
7 times, most recently
from
0f3377e to
170df2b
Compare
Contributor
Author
|
hmm it seems I have changed runtime behavior. although I would say that you shouldn't be putting side effects in your asserts but it still changed behavior I think I will leave the bitfields out but keep the null thingy |
ZXShady
force-pushed
the
more_comparisons
branch
14 times, most recently
from
aa89ed3 to
12b3982
Compare
ZXShady
force-pushed
the
more_comparisons
branch
4 times, most recently
from
d68e514 to
d2497d9
Compare
Allow NULL macro comparison
ZXShady
force-pushed
the
more_comparisons
branch
from
d2497d9 to
e3d52f5
Compare
Contributor
Author
|
@jeremy-rifkin I decided to remove the bit field checking since it is a little bit buggy and requires C++20, i kept the null constant checking, and fixed invalid code from compiling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
and #152Also fixes the issue of
ASSERT(1 = 5)compiling