Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Good Practices #31

Open
EdixonAlberto opened this issue Jun 25, 2019 · 0 comments
Open

Good Practices #31

EdixonAlberto opened this issue Jun 25, 2019 · 0 comments

Comments

@EdixonAlberto
Copy link
Contributor

apply good practices using PSRs
@EdixonAlberto EdixonAlberto changed the title good practices Good Practices Jun 25, 2019
EdixonAlberto added a commit to EdixonAlberto/tiny-html-minifier that referenced this issue Jun 25, 2019
@EdixonAlberto
apply good practices jenstornell#31
7dc3c4b 
- adding keywords and require empty in composer.
- establishing variables within classes as private.
- placing the visibility of the functions inside the classes (public | private).
- placing explicitly the type of data in the arguments of some functions, as well as the type of output.
- Separating the classes in different files.
- adapting spaces and identacion in the classes according to PSR-2.
- moving classes to /src path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EdixonAlberto