Skip to content

docs(rfc): flip RFC 0044 to green — all nine criteria pass - #676

Merged
jensholdgaard merged 1 commit into
mainfrom
rfc0044-green
Jul 29, 2026
Merged

docs(rfc): flip RFC 0044 to green — all nine criteria pass#676
jensholdgaard merged 1 commit into
mainfrom
rfc0044-green

Conversation

@jensholdgaard

Copy link
Copy Markdown
Owner

Summary

RFC 0044 (template-aware body equality) goes specifiedgreen, same-day, across five slices: #671 matcher, #672 two-arm compile (closed #664), #673 renames/reversions with the alias-exclusion refinement, #674 pruning fixtures, #675 the .9 property — generative and every line of the committed §3.3 corpus. The banner records the three implementation-forced refinements (candidate superset + scan-time exactness; alias expansion excluded as wrong; no IS TRUE on equality — it defeats pruning and NULL ≡ false under a filter). Frontmatter and banner flipped together. accepted is a maintainer flip.

mdbook build clean; docs-only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard requested a review from Copilot July 29, 2026 11:00
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f836ae30-f858-42b2-91b7-22c387e83abe

📥 Commits

Reviewing files that changed from the base of the PR and between dd5608e and 9c5cf99.

📒 Files selected for processing (1)
  • docs/rfcs/0044-template-aware-body-equality.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates RFC 0044 (template-aware body equality) documentation to reflect that the RFC has reached the green maturity stage, recording that all nine §5 acceptance criteria have passing coverage across the referenced implementation slices.

Changes:

  • Flip RFC 0044 frontmatter status from specified to green.
  • Replace the RFC banner to summarize the five landed slices and explicitly document the three implementation-forced refinements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jensholdgaard
jensholdgaard merged commit f51a6e1 into main Jul 29, 2026
28 checks passed
@jensholdgaard
jensholdgaard deleted the rfc0044-green branch July 29, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

body equality predicate silently misses template-mined records (row group pruned on the NULL body column)

2 participants