Skip to content

docs(rfc): flip RFC 0043 to green — all seven criteria pass - #670

Merged
jensholdgaard merged 2 commits into
mainfrom
rfc0043-green
Jul 29, 2026
Merged

docs(rfc): flip RFC 0043 to green — all seven criteria pass#670
jensholdgaard merged 2 commits into
mainfrom
rfc0043-green

Conversation

@jensholdgaard

@jensholdgaard jensholdgaard commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

RFC 0043 (event_name from the legacy event.name attribute) goes specifiedgreen: #668 landed the derivation with RFC0043.1–.4/.7 at the materialisation boundary (both encodings through the one seam), #669 closed .5 (the end-to-end event_name == query over attr-only records through the real miner and store) and .6 (keying engagement via the id-separation observable, criterion refined inline in #669). Frontmatter and banner flipped together. No thesis-gate applies; accepted is a maintainer flip.

mdbook build clean; docs-only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F

Summary by CodeRabbit

  • Documentation
    • Updated the event name ingestion RFC status to reflect its completed rollout.
    • Clarified that all defined criteria have been satisfied and that event names are preserved verbatim through derivation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard requested a review from Copilot July 29, 2026 00:12
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d1c7c7c2-6d8d-48bc-99d9-0b5ce6483120

📥 Commits

Reviewing files that changed from the base of the PR and between 0ddf7d6 and 33cb22b.

📒 Files selected for processing (1)
  • docs/rfcs/0043-event-name-attribute-ingest.md
📝 Walkthrough

Walkthrough

RFC 0043 now marks its implementation status as green. Its Status section documents completed §5 criteria and the resolved §7 fidelity interpretation, including additive derivation of event_name while preserving the legacy attribute verbatim.

Changes

RFC 0043 status update

Layer / File(s) Summary
Update RFC status and completion narrative
docs/rfcs/0043-event-name-attribute-ingest.md
The front matter changes from specified to green, and the Status section records completed criteria and the resolved fidelity/design interpretation.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The summary is detailed, but the required Related and Checklist sections from the template are missing. Add a Related section with issue/RFC links and complete the Checklist with fmt, clippy, tests, docs, and RFC-link items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes updating RFC 0043 from specified to green, which matches the main documentation change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rfc0043-green

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates RFC 0043’s status and banner to reflect that all §5 acceptance criteria now pass, moving the RFC from specified to green (docs-only, no code changes).

Changes:

  • Flip RFC 0043 frontmatter status to green.
  • Update the RFC status banner to summarize which PRs/tests satisfied each criterion and note that accepted remains a maintainer flip.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/rfcs/0043-event-name-attribute-ingest.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/rfcs/0043-event-name-attribute-ingest.md`:
- Around line 14-25: Update the RFC status line to use the actual
review/completion date of July 28, 2026, or defer the status transition until
July 29; keep the existing status and criteria details unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b803ddcb-1d0f-41fe-b71a-b2c979040f29

📥 Commits

Reviewing files that changed from the base of the PR and between 6b6d926 and 0ddf7d6.

📒 Files selected for processing (1)
  • docs/rfcs/0043-event-name-attribute-ingest.md

Comment thread docs/rfcs/0043-event-name-attribute-ingest.md Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard merged commit 8a31f61 into main Jul 29, 2026
27 checks passed
@jensholdgaard
jensholdgaard deleted the rfc0043-green branch July 29, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants