feat(semconv): register datafusion.operator.* attributes (RFC 0040 slice 2)

[jensholdgaard]

Summary

• New registry.datafusion group in semconv/registry/attributes.yaml: the five normative operator-span attributes RFC 0040 §3.3 specifies (output_rows, elapsed_compute, output_bytes, row_groups_pruned, row_groups_matched) — kept as their own group, separate from registry.ourios, since they describe DataFusion's semantics, not Ourios's (the crate is built to be extracted to a standalone datafusion-contrib component).
• Regenerated crates/ourios-semconv/src/lib.rs (weaver registry generate) — 5 new constants, no other diff.
• ourios-df-otel (merged in slice 1, feat(df-otel): post-hoc ExecutionPlan -> OTel operator span crate (RFC 0040 slice 1) #632) keeps its own local string constants rather than depending on ourios-semconv — that dependency would break its zero-ourios-*-dep design. This registration exists so weaver registry live-check recognizes the names once slice 3 wires emission into ourios-querier, instead of flagging them as unregistered violations.

Related

RFC: docs/rfcs/0040-datafusion-operator-instrumentation.md (slice 2 of 4)

Checklist

• weaver registry check -r semconv/registry --future clean
• weaver registry generate + cargo fmt -p ourios-semconv produces exactly this diff (no drift)
• cargo test -p ourios-semconv --all-features (3/3 pass)
• cargo clippy -p ourios-semconv --all-targets --all-features -- -D warnings clean
• cargo fmt -p ourios-semconv --check clean
• Docs / CHANGELOG.md — not user-facing yet (no emission until slice 3)
• RFC linked

[coderabbitai]

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a4f2055d-f891-4a47-8c2e-68e30b3c74d9

📥 Commits

Reviewing files that changed from the base of the PR and between f14e2cc and 6542458.

📒 Files selected for processing (2)

• crates/ourios-semconv/src/lib.rs
• semconv/registry/attributes.yaml

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0040-slice2-weaver-registry

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Registers the RFC 0040 §3.3 datafusion.operator.* attribute keys in the Weaver semconv registry so future operator-span emission (slice 3) can pass weaver registry live-check without “unregistered attribute” violations.

Changes:

• Add a new registry.datafusion attribute group defining five datafusion.operator.* attributes.
• Regenerate crates/ourios-semconv/src/lib.rs to include the corresponding constant keys.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
semconv/registry/attributes.yaml	Adds registry.datafusion and defines the five operator-span attributes.
crates/ourios-semconv/src/lib.rs	Regenerated semconv constants for the new datafusion.operator.* keys.

Comments suppressed due to low confidence (1)

semconv/registry/attributes.yaml:366

• The brief for datafusion.operator.row_groups_matched calls this value the “B1 denominator”, which is an Ourios benchmark-specific concept. To keep this attribute definition reusable outside Ourios (as the surrounding comment suggests), remove the B1 reference and describe only the DataFusion/Parquet meaning.

          Parquet row groups this scan read (`PruningMetrics::matched`) —
          the B1 denominator. Reported as a raw count alongside

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.