feat(telemetry)!: per-signal disable via OTEL_{METRICS,LOGS}_EXPORTER=none (closes #618)

[jensholdgaard]

Per-signal disable via the universal OTEL_*_EXPORTER env vars (closes #618)

The metrics/logs half of #618 — the same "lean into universal OTel SDK env vars" move RFC 0038 slice 4 (#619) made for traces, completing all three signals. With #620 (metric interval → OTEL_METRIC_EXPORT_INTERVAL) merged, this closes #618.

ourios-telemetry is the autoconfigure layer

Confirmed with the OTel MCP: the OTEL_{TRACES,METRICS,LOGS}_EXPORTER selector (incl. none) is an autoconfigure/autoexport responsibility — Go's contrib/exporters/autoexport, Java's sdk-extension-autoconfigure — not the core SDK, and Rust has no autoexport crate (grepped every opentelemetry* crate: zero matches). Since Ourios builds its exporters manually (RFC 0001 §6.8 split), init() now plays that autoconfigure role itself:

• init() reads OTEL_{TRACES,METRICS,LOGS}_EXPORTER (+ OTEL_SDK_DISABLED) directly: a signal installs only when its config.*_enabled flag, the global kill-switch, and the per-signal selector all agree. none → off; unset / otlp / any other → on (always OTLP — Ourios doesn't implement the full selector).
• The server drops its mapping — it just calls init(TelemetryConfig::new(...)). Operators use only the universal env vars; no bespoke Ourios telemetry config to map.
• TelemetryGuard.provider becomes Option<SdkMeterProvider> (matching tracer: Option); metrics off → instruments resolve to the global no-op, logs off → the tracing→OTel bridge is dropped but the stderr fmt layer stays. The *_enabled flags remain as programmatic overrides (default on, testable).

Tests

• exporter_selected_treats_none_as_off — the pure selector mapping (none → off; else on).
• init_with_signals_disabled_installs_no_pipelines — all flags off → guard owns no meter/logger/tracer provider.

OTEL_EXPORTER_OTLP_* still tune the transport.

BREAKING CHANGE: TelemetryConfig gains metrics_enabled/logs_enabled and drops nothing callers set (::new defaults all three flags to true, so ::new() callers are unaffected); exhaustive struct-literal constructors must set the new fields.

🤖 Generated with Claude Code

[coderabbitai]

📝 Walkthrough

Walkthrough

The server now maps standard OpenTelemetry exporter variables to independent signal toggles. Telemetry initialization conditionally creates metrics, logs, and tracing providers, with optional guard ownership, shutdown, flushing, subscriber wiring, and tests updated accordingly.

Changes

OpenTelemetry signal controls

Layer / File(s)	Summary
Per-signal environment mapping crates/ourios-server/src/main.rs	signal_enabled disables a signal only for case- and whitespace-insensitive none values, and main() applies it to traces, metrics, and logs.
Optional provider ownership crates/ourios-telemetry/src/lib.rs	TelemetryConfig adds metrics and logs toggles, while TelemetryGuard conditionally owns and manages providers.
Conditional pipeline initialization crates/ourios-telemetry/src/lib.rs	init creates only enabled pipelines, conditionally installs the logging bridge and meter provider, handles installation failures, and updates initialization tests.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant main
  participant signal_enabled
  participant init
  participant telemetry_providers
  main->>signal_enabled: Read per-signal OTEL exporter variables
  signal_enabled-->>main: Return enabled or disabled signals
  main->>init: Pass TelemetryConfig
  init->>telemetry_providers: Create enabled providers
  telemetry_providers-->>init: Return optional providers
  init-->>main: Install subscriber and return TelemetryGuard

Loading

Possibly related PRs

• jensholdgaard/ourios#619: Introduces the traces exporter disablement flow that this change generalizes to metrics and logs.
• jensholdgaard/ourios#614: Also changes conditional telemetry provider construction and ownership.
• jensholdgaard/ourios#334: Adds the OTLP log pipeline and optional logger provider touched by this refactor.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR implements the linked issue's main goals by honoring per-signal OTEL disable env vars and preserving OTLP transport settings.
Out of Scope Changes check	✅ Passed	The changes stay focused on telemetry signal disable behavior, config wiring, and tests, with no clear unrelated additions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title is concise and accurately summarizes the main telemetry change.
Description check	✅ Passed	The description covers the summary and related issue context, but it omits the template's explicit checklist section.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0038-metrics-logs-disable

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Extends Ourios telemetry bootstrap to support per-signal disabling of metrics and logs via standard OpenTelemetry env vars (OTEL_METRICS_EXPORTER=none, OTEL_LOGS_EXPORTER=none), matching the existing traces behavior and keeping Ourios’ telemetry configuration aligned with upstream OTel conventions.

Changes:

• Add metrics_enabled and logs_enabled flags to TelemetryConfig (default true) and make the meter provider optional (TelemetryGuard.provider: Option<SdkMeterProvider>).
• Update ourios_telemetry::init() to skip installing the metrics provider when metrics are disabled and to skip constructing the OTLP logger + tracing→OTel-logs bridge when logs are disabled.
• Replace the traces-only env mapping helper with a shared signal_enabled() that applies the …_EXPORTER=none → off mapping for traces/metrics/logs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/ourios-telemetry/src/lib.rs	Add per-signal enable flags; make metrics provider optional; conditionally build/install metrics + logs pipelines based on flags.
crates/ourios-server/src/main.rs	Map OTEL_{TRACES,METRICS,LOGS}_EXPORTER via shared signal_enabled() into TelemetryConfig flags; update unit test accordingly.

Comments suppressed due to low confidence (1)

crates/ourios-telemetry/src/lib.rs:303

• The new logs_enabled branch is also untested. A focused unit test can catch accidental reintroduction of the OTLP logger/bridge when disabled (e.g., use an invalid otlp_endpoint and assert init() still succeeds when logs_enabled=false but fails when logs_enabled=true).

    // guard to shut down. `None` when disabled (`OTEL_LOGS_EXPORTER=none`);
    // the stderr `fmt` layer stays, so only the OTel Logs signal is dropped.
    let logger: Option<SdkLoggerProvider> = if config.logs_enabled {
        let mut builder = LogExporter::builder().with_tonic();
        if let Some(endpoint) = &config.otlp_endpoint {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/ourios-telemetry/src/lib.rs`:
- Around line 268-315: Update TelemetryConfig::new and init so
OTEL_SDK_DISABLED=true overrides the individual signal-enabled flags before
building metric, logger, or tracer pipelines. Ensure no OTLP providers are
constructed and all corresponding TelemetryGuard fields are None, while
preserving existing per-signal exporter behavior when the global flag is unset;
add a regression test covering the disabled configuration.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f13b10dd-092e-4575-9987-a757efd72ee4

📥 Commits

Reviewing files that changed from the base of the PR and between 577b8ff and 2d4a5ed.

📒 Files selected for processing (2)

• crates/ourios-server/src/main.rs
• crates/ourios-telemetry/src/lib.rs

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

crates/ourios-telemetry/src/lib.rs:272

• After introducing metrics_enabled/logs_enabled/traces_enabled, init can legitimately install only a subset of pipelines (or none). The rustdoc immediately above init still states it always builds the OTLP MeterProvider and OTLP LoggerProvider, which is now misleading.

pub fn init(config: &TelemetryConfig) -> Result<TelemetryGuard, TelemetryError> {
    let resource = resource(&config.service_name);

    // Metrics: `None` when disabled (`OTEL_METRICS_EXPORTER=none` → the server
    // clears `metrics_enabled`), so instruments resolve to the global no-op and

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.