Skip to content

docs(rfc): RFC 0022 green → validated on the §9.9 + §9.11 evidence - #545

Merged
jensholdgaard merged 4 commits into
mainfrom
rfc0022-validated
Jul 18, 2026
Merged

docs(rfc): RFC 0022 green → validated on the §9.9 + §9.11 evidence#545
jensholdgaard merged 4 commits into
mainfrom
rfc0022-validated

Conversation

@jensholdgaard

@jensholdgaard jensholdgaard commented Jul 18, 2026

Copy link
Copy Markdown
Owner

What

Doc-only: flips RFC 0022 (queryable attribute columns) green → validated — the evidence already existed in benchmarks.md; only the status flip was never made.

The trail, verified before flipping:

  • §9.9 (indicative ci-runner, 2026-07-03, git 6e3301b — the green merge itself): B1 34.8× against the ≥ 10× bar, B2 flat few-ms windowed latencies, no regression from the promoted-column write path or the two-arm predicate compile (the RFC0022.5 contract), with the pruning counters pinned structurally in rfc0022_attr_columns.rs. That entry explicitly named the authoritative baseline rerun as the outstanding green → validated step.
  • §9.11 (authoritative baseline-8vcpu-32gib, 2026-07-04, git 19e0886): the first ≥ 10 GiB B1/B2 readings, both PASS (authoritative) — and git merge-base --is-ancestor confirms 19e0886 descends from 6e3301b, so the promoted-column machinery was in the measured tree.

Per docs/rfcs/README.md, the validated → accepted flip stays a maintainer step.

Checks run

mdbook build (clean); ancestry verified with git merge-base --is-ancestor. Doc-only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y

Summary by CodeRabbit

  • Documentation
    • Updated the RFC maturity status from “green” to “validated.”
    • Added a dated note documenting supporting benchmark and regression evidence.
    • Clarified that final maintainer acceptance remains pending.

The validation evidence already existed, only the flip was missing:
§9.9 (indicative, at the green merge 6e3301b) showed B1/B2 unchanged
per the RFC0022.5 contract and named the authoritative rerun as the
outstanding step; §9.11 (authoritative baseline, 19e0886 — verified a
descendant of 6e3301b) delivered it the next day with both verdicts
PASS at the first >=10 GiB readings. Status note records the trail;
accepted stays a maintainer flip.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
@jensholdgaard
jensholdgaard requested a review from Copilot July 18, 2026 17:51
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e71d3a8f-f3d1-451b-b6c5-2924f09f853e

📥 Commits

Reviewing files that changed from the base of the PR and between 3a3d4df and d1ab34e.

📒 Files selected for processing (1)
  • docs/rfcs/0022-queryable-attribute-columns.md
📝 Walkthrough

Walkthrough

RFC0022 is marked validated, and the document adds a dated note recording benchmark/regression evidence for that transition while noting that maintainer acceptance remains pending.

Changes

RFC0022 validation

Layer / File(s) Summary
Status metadata and evidence note
docs/rfcs/0022-queryable-attribute-columns.md
Updates the RFC status from green to validated and documents the benchmark/regression evidence supporting the change, while retaining validated → accepted as pending.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the RFC 0022 status change from green to validated and references the supporting evidence.
Description check ✅ Passed The description covers the change and verification, but it does not follow the template's Summary, Related, and Checklist sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rfc0022-validated

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates RFC 0022’s maturity state from green to validated, documenting that the already-recorded benchmark evidence in docs/benchmarks.md satisfies the RFC’s no-regression contract and the bench-ladder “validated” gate defined by the RFC process.

Changes:

  • Flip RFC 0022 frontmatter status from greenvalidated.
  • Add a short “Status note” blockquote summarizing the supporting benchmark entries and commits for the status flip.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/rfcs/0022-queryable-attribute-columns.md Outdated
The maturity model lives under "## Lifecycle" in docs/rfcs/README.md,
not a "maturity stages" section (Copilot).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread docs/rfcs/0022-queryable-attribute-columns.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread docs/rfcs/0022-queryable-attribute-columns.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@jensholdgaard
jensholdgaard merged commit f0d5fea into main Jul 18, 2026
25 of 26 checks passed
@jensholdgaard
jensholdgaard deleted the rfc0022-validated branch July 18, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants