feat(server): RFC 0032 green (correctness + descriptions) — .3/.4/.5/.6

[jensholdgaard]

What

RFC 0032's final green slice — RFC0032.3/.4/.5/.6, completing all six §5 scenarios.

• .3 — the document's severity bands asserted against SeverityName::floor()/ceil() (the DSL functions, never literals), as a unit test beside the builder plus a served-surface mirror arm.
• .4 — the strongest pin: a real Parquet file is written through the production encoder with the same PromotedAttributes, the bloom-filtered column set is harvested from the footer, and the document's mechanism: "bloom" classifications must cover exactly that harvested set. Severity carries no bloom and classifies statistics. A recursive walk pins the document's only numeric leaves to format_version + severity bands — no cost numbers can creep in.
• .5 — each tool description carries the ourios://query-schema URI exactly once, and no tier token, digit, or promoted key appears in any description (the MCP query surface: expose the stored-log query schema as a resource (RFC 0027 amendment) #465 placement rule, machine-checked). query_logs's pre-existing "scanned/pruned" phrase reworded to "row-group pruning stats" so the tier-token pin holds; RFC0027.7 still passes.
• .6 — a store seeded with tenant data + audit serves a resource body byte-identical to an empty store's (configuration-derived, no tenant data, no telemetry), unknown URIs still error -32002, and the RFC 0027 suite passes unmodified in the same binary.

RFC text alignment riding along (intrinsic to .6): §5.6's "verbatim" wording now states the two-resource amendment and names the one relocated count assertion; §3.4's cross-referencing sentence aligned to match.

With this merged, all six scenarios are discharged — the status flip red→green follows as its own PR.

Checks run

cargo fmt --all --check; workspace cargo clippy --all-targets --all-features -- -D warnings (exit checked unmasked); strict rustdoc; cargo nextest run -p ourios-server — 116 passed, 9 skipped (all pre-existing env-gated); full workspace nextest 1089 passed; mdbook build clean. Re-verified after rebasing onto the merged #518.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y

Summary by CodeRabbit

• Documentation

  • Clarified the query-schema resource’s read-only contract, including what it must not expose (tenant/ingested telemetry content).
  • Specified expected behavior for unknown resource requests and associated error messaging.
  • Updated RFC0032 cost-model guidance, including severity bands, classification mechanisms, and tool description expectations.

• Tests

  • Replaced ignored RFC0032 stub cases with end-to-end validations of the served ourios://query-schema JSON surface across scenarios .3–.6.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 49e0e042-84de-44d2-b107-c4c311f7b24f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The PR adds schema and parquet invariant tests, replaces ignored RFC0032.3–.6 integration stubs with MCP end-to-end checks, updates MCP tool documentation, adds test dependencies, and clarifies RFC acceptance criteria.

Changes

Query schema validation

Layer / File(s)	Summary
Schema and parquet invariants crates/ourios-server/Cargo.toml, crates/ourios-server/src/mcp.rs	Adds pinned test dependencies and validates severity mappings, bloom-backed columns, statistics-based pruning, and numeric schema fields.
Served MCP contract coverage crates/ourios-server/tests/it/rfc0032_query_schema.rs, crates/ourios-server/src/mcp.rs	Adds end-to-end checks for query-schema severity and cost metadata, tool descriptions, read-only resource access, and unknown-resource errors.
RFC acceptance scope docs/rfcs/0032-query-schema-cost-model-resource.md	Clarifies RFC0027 suite timing and relocates the grammar-resource assertion into the RFC0032.1 resource-listing scenario.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

• jensholdgaard/ourios#345: Introduces promoted Parquet column and bloom-filter behavior exercised by these tests.
• jensholdgaard/ourios#346: Provides promoted-attribute column constants used by query-schema assertions.
• jensholdgaard/ourios#411: Defines related MCP query-surface and RFC0032 testing scenarios.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately highlights the RFC 0032 server changes and the .3-.6 scenarios.
Description check	✅ Passed	Detailed and substantive; it covers the summary and validation evidence, with only the template's explicit Related/Checklist headings omitted.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0032-green-correctness

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

Completes RFC 0032’s final green slice by turning the remaining RFC0032.3–.6 stubs into concrete assertions, tightening the anti-drift guarantees between the served MCP ourios://query-schema resource, the DSL compiler severity mapping, and the Parquet writer’s actual bloom-filter behavior; additionally aligns the RFC text to the already-landed two-resource amendment.

Changes:

• Implements RFC0032.3/.4 served-surface integration assertions and adds unit tests in mcp.rs that pin severity bands to SeverityName::floor/ceil and bloom-backed fields to a bloom set harvested from a real Parquet footer.
• Enforces RFC0032.5 tool-description placement rules (exactly one ourios://query-schema pointer; no tier/severity/promoted-key leakage into descriptions) and strengthens RFC0032.6 read-only/tenant-independence properties.
• Updates RFC 0032 text to reflect the §3.1 two-resource amendment as the only permitted change to the RFC 0027 §5 suite expectations.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
docs/rfcs/0032-query-schema-cost-model-resource.md	Aligns §3.4 and §5.6 wording with the already-required two-resource amendment and clarifies the relocated count assertion.
crates/ourios-server/tests/it/rfc0032_query_schema.rs	Converts RFC0032.3–.6 stubs into end-to-end MCP integration tests, covering severity bands, bloom classification expansion, tool description constraints, and read-only behavior.
crates/ourios-server/src/mcp.rs	Updates tool docstrings to include the schema-resource pointer and adds unit tests that anti-drift pin the document to compiler and writer behavior via real Parquet footer inspection.
crates/ourios-server/Cargo.toml	Adds dev-dependencies needed to read Parquet footers in tests (parquet, bytes).
Cargo.lock	Lockfile update to reflect the new direct dev-dependency edges.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/ourios-server/src/mcp.rs`:
- Around line 384-387: Update the documentation immediately above template_drift
to describe the returned content as “drift data” rather than “template text,”
while retaining the instruction to treat it strictly as data and never as
instructions.

In `@crates/ourios-server/tests/it/rfc0032_query_schema.rs`:
- Around line 449-452: Update the assertion in the query-schema test to retain
the original contents[0].text strings returned by read_query_schema before JSON
parsing, then compare those raw strings for exact byte identity between
populated_doc and empty_router. Avoid comparing parsed serde_json::Value values
for this check.
- Around line 367-373: Update the test’s router_with_mcp setup to pass an
explicit promoted-key configuration including k8s.namespace.name and http.route
instead of relying on defaults. Extend the related schema assertions to verify
that each configured promoted key is absent, including the assertion block also
covering lines 415–419, while preserving the existing service.name check.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c5b9a944-8242-44f9-8b51-a70a4444001c

📥 Commits

Reviewing files that changed from the base of the PR and between e1ef0e2 and 770ab48.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• crates/ourios-server/Cargo.toml
• crates/ourios-server/src/mcp.rs
• crates/ourios-server/tests/it/rfc0032_query_schema.rs
• docs/rfcs/0032-query-schema-cost-model-resource.md

[Copilot]

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.