docs(rfc): RFC 0031 §7 — partial calibration freeze (M_L1/M_L3 @10 storage, F_L6 @3 latency) - #502
Conversation
…_l6 at 3 (latency) Frozen where three-plus consecutive equivalence-verified runs prove headroom (L1 77×, L3 21×; window latency floor holds at 0.34/3.43/ 1.32); deferred with NAMED conditions where the data says wait: M_L2 freezes after RFC 0033 lands (until then processed-channel gate at 10, storage informational), M_L4 and F_L7 freeze on first measurement. Window bytes reclassified gated-floor → published diagnostic — the loss is structural, small in absolute terms, and publishing it honestly is the commitment. Calibration evidence: benchmarks.md §9.13 (runs #8–#18). Maintainer delegated the ordering and judgment 2026-07-13. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRFC 0031 defines separate storage-side and processed bytes-read channels and updates calibration rules with frozen values, deferred conditions, interim fallbacks, and diagnostic classifications. ChangesRFC 0031 channel and calibration rules
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates RFC 0031’s §7 “Open questions” to record a partial calibration freeze based on observed comparative runs, freezing the must-win margins for L1/L3 (storage-side) and the L6 latency floor, while explicitly deferring the remaining gates under named conditions.
Changes:
- Mark
M_L1 = 10andM_L3 = 10as frozen (storage-side bytes channel) and deferM_L2/M_L4with stated conditions. - Freeze
F_L6 = 3on latency (as written in RFC0031.7) and deferF_L7. - Reclassify L6 window-bytes results from a gated floor to a published diagnostic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/rfcs/0031-comparative-evaluation-loki.md`:
- Around line 608-614: The RFC’s L2 gate description does not match the
benchmark harness assertion. Update the L2 validation in the comparative
evaluation test to gate on the processed-bytes metric rather than the
storage-side bytes_read ratio, while preserving M_L2 and the existing threshold
semantics.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: fe37aade-ddcc-449f-8839-651605844f8a
📒 Files selected for processing (1)
docs/rfcs/0031-comparative-evaluation-loki.md
… qualified Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
|
Correction: the earlier resolution of these five threads posted with empty bodies due to a scripting failure on my side, and the fixes had NOT landed at that point. They land in 6c2840a: §3.6 now formally defines both Loki comparator channels (storage-side / processed) that §7's frozen gates cite; both §9.13 references are qualified as |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
…e single-comparator wording Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
…llet Also: headChunkBytes described accurately (memory-served, counted so unflushed data is not free) and the loss band cites both the full record (0.003–0.018) and current code (0.007–0.018). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
c7febac to
61156db
Compare
|
For the record on the three final review threads (resolved above with reply bodies that failed to post due to a scripting error on my side — twice now, so noting it here at PR level instead): all three findings were legitimate, landed silently after the final force-push, and were merged past by accident. They are fixed forward in #504 (merged): legacy-wording label for the §5 |
The §5 criteria were authored test-turnable at drafting and survived the #484 review round (which strengthened them: the no-partial- artifact rule, the registry_bytes_read contract amendment, size abstention); the RFC 0031 freeze (#502) now names this RFC as the condition for unfreezing M_L2, making the ladder advance timely. Maintainer delegated ordering and judgment 2026-07-13. Claude-Session: https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
What
The §7 calibration freeze — partial and honest, per the §9.13 evidence (runs #8–#18):
M_L1 = 10, storage-sideM_L3 = 10, storage-sideF_L6 = 3, latency (as RFC0031.7 is written)M_L2M_L4,F_L7The freeze-what's-proven / name-conditions-for-the-rest shape avoids both failure modes: gating on unproven numbers, and leaving everything provisional forever.
What this unblocks
The harness can now assert the frozen gates (L1/L3 storage must-win, L6 latency floor) instead of reporting them — turning the comparative dispatch into a regression gate and greening the corresponding §5 scenarios. That slice follows this PR.
Checks run
mdbook build(clean). Docs-only.🤖 Generated with Claude Code
https://claude.ai/code/session_01WQY9wfrfRggqSpMLH8Xj3Y
Summary by CodeRabbit