Skip to content

fix(bench): RFC 0031 — raise Loki's internal gRPC cap (single-line inflation) #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensholdgaard merged 2 commits into from
Jul 11, 2026
Merged

fix(bench): RFC 0031 — raise Loki's internal gRPC cap (single-line inflation) #478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be8b9e0
fix(bench): raise Loki's internal gRPC cap — single-line inflation (r…
jensholdgaard Jul 11, 2026
a9caffa
fix(bench): correct dskit flag names for the gRPC msg-size cap
jensholdgaard Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions crates/ourios-bench/tests/rfc0031_comparative.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,17 @@ fn rfc0031_indicative_comparative_run() {
"-distributor.ingestion-burst-size-mb=1024",
"-ingester.per-stream-rate-limit=512MB",
"-ingester.per-stream-rate-limit-burst=1GB",
// Runs #2–#4 all failed on the SAME ~5.27 MB internal message
// regardless of our batch size (3 MiB → 1.5 MB outer), proving
// a single `kafka`-service LogsData line's content alone
// inflates past the stock 4 MiB internal gRPC cap. Raising the
// cap (standard operator tuning, in Loki's favour — it lets
// Loki accept the data at all) preserves the identical-ingest
// precondition the equivalence check requires; skipping the
// line would silently unequalize the two corpora. Flag names
// per dskit's server registry (grpc_server_max_*_msg_size).
"-server.grpc-max-recv-msg-size-bytes=16777216",
"-server.grpc-max-send-msg-size-bytes=16777216",
])
.await;
push_corpus_to_loki(&http, &base, &corpus_dir).await;
Expand Down